diff options
| author | Samasth Norway Ananda | 2026-01-05 12:38:33 -0800 |
|---|---|---|
| committer | Dave Jiang | 2026-01-22 16:58:13 -0700 |
| commit | 4dd05f02f1d618da610e7d3bd479c47a96b4fc3f (patch) | |
| tree | 9866ce28e9d40ad16cc993fcdcb107120a5be173 /drivers | |
| parent | 7362facf6ec14f70fe28413cb484639d783b89f0 (diff) | |
cxl/pci: Remove outdated FIXME comment and BUILD_BUG_ON
Remove the outdated FIXME comment about switching to struct_group() and
the associated BUILD_BUG_ON check. This work was already completed in
commit 301e68dd9b9b ("cxl/core: Replace unions with struct_group()")
which converted struct cxl_regs to use struct_group_tagged().
The BUILD_BUG_ON was checking that anonymous union layout was preserved,
but since struct_group() now handles this correctly, the compile-time
check is no longer necessary.
Signed-off-by: Samasth Norway Ananda <samasth.norway.ananda@oracle.com>
Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Link: https://patch.msgid.link/20260105203833.1604585-1-samasth.norway.ananda@oracle.com
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/cxl/pci.c | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/cxl/pci.c b/drivers/cxl/pci.c index 0be4e508affe..3b2293dffb3f 100644 --- a/drivers/cxl/pci.c +++ b/drivers/cxl/pci.c @@ -912,13 +912,6 @@ static int cxl_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id) unsigned int i; bool irq_avail; - /* - * Double check the anonymous union trickery in struct cxl_regs - * FIXME switch to struct_group() - */ - BUILD_BUG_ON(offsetof(struct cxl_regs, memdev) != - offsetof(struct cxl_regs, device_regs.memdev)); - rc = pcim_enable_device(pdev); if (rc) return rc; |