kernel.git/sound/usb/clock.c, branch linux-3.2.y

ALSA: usb-audio: Add sanity checks in v2 clock parsers

2018-02-13T18:32:20Z

commit 0a62d6c966956d77397c32836a5bbfe3af786fc1 upstream. The helper functions to parse and look for the clock source, selector and multiplier unit may return the descriptor with a too short length than required, while there is no sanity check in the caller side. Add some sanity checks in the parsers, at least, to guarantee the given descriptor size, for avoiding the potential crashes. Fixes: 79f920fbff56 ("ALSA: usb-audio: parse clock topology of UAC2 devices") Reported-by: Andrey Konovalov Signed-off-by: Takashi Iwai Signed-off-by: Ben Hutchings

ALSA: usb-audio: Add sanity checks for endpoint accesses

2016-04-30T22:05:18Z

commit 447d6275f0c21f6cc97a88b3a0c601436a4cdf2a upstream. Add some sanity check codes before actually accessing the endpoint via get_endpoint() in order to avoid the invalid access through a malformed USB descriptor. Mostly just checking bNumEndpoints, but in one place (snd_microii_spdif_default_get()), the validity of iface and altsetting index is checked as well. Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=971125 Signed-off-by: Takashi Iwai [bwh: Backported to 3.2: drop changes to code we don't have] Signed-off-by: Ben Hutchings

ALSA: snd-usb: fix clock source validity index

2012-08-09T23:25:11Z

commit aff252a848ce21b431ba822de3dab9c4c94571cb upstream. uac_clock_source_is_valid() uses the control selector value to access the bmControls bitmap of the clock source unit. This is wrong, as control selector values start from 1, while the bitmap uses all available bits. In other words, "Clock Validity Control" is stored in D3..2, not D5..4 of the clock selector unit's bmControls. Signed-off-by: Daniel Mack Reported-by: Andreas Koch Signed-off-by: Takashi Iwai Signed-off-by: Ben Hutchings

ALSA: usb-audio: increase control transfer timeout

2011-09-27T07:21:48Z

There are certain devices that are reportedly so slow that they need more than 100 ms to handle control transfers. Therefore, increase the timeout in mixer(_quirks).c to 1000 ms. The timeout parameter of snd_usb_ctl_msg() is now constant, so we can drop it. Reported-by: Felipe Balbi Signed-off-by: Clemens Ladisch Signed-off-by: Takashi Iwai

ALSA: usb-audio: assume valid clock

2011-05-18T09:44:44Z

If the interface can't report a clock's validity, assume that it's valid. Signed-off-by: Daniel Mack Reported-by: Vicente Joel Signed-off-by: Takashi Iwai

ALSA: usb-audio: fix detection of vendor-specific device protocol settings

2010-09-03T20:36:39Z

The Audio Class v2 support code in 2.6.35 added checks for the bInterfaceProtocol field. However, there are devices (usually those detected by vendor-specific quirks) that do not have one of the predefined values in this field, which made the driver reject them. To fix this regression, restore the old behaviour, i.e., assume that a device with an unknown bInterfaceProtocol field (other than UAC_VERSION_2) has more or less UAC-v1-compatible descriptors. [compile warning fixes by tiwai] Signed-off-by: Clemens Ladisch Cc: Daniel Mack Cc: Signed-off-by: Takashi Iwai

ALSA: usb-audio: silence a superfluous warning

2010-07-09T13:08:12Z

It is not advisable to print a warning when a device does not support setting the sample rate because this is perfectly valid for devices with a single rate or where rates are implicitly changed by selecting another alternate setting. Signed-off-by: Clemens Ladisch Signed-off-by: Takashi Iwai

ALSA: usb-audio: simplify control interface access

2010-06-23T14:10:23Z

As the control interface is now carried in struct snd_usb_audio, we can simplify the API a little and also drop the private ctrlif field from struct usb_mixer_interface. Also remove a left-over function prototype in pcm.h. Signed-off-by: Daniel Mack Signed-off-by: Takashi Iwai

ALSA: usb-audio: move and add some comments

2010-06-23T14:09:50Z

Also add a list of open topics. Signed-off-by: Daniel Mack Signed-off-by: Takashi Iwai

ALSA: usb-audio: clean up includes in clock.c

2010-06-23T14:09:14Z

Signed-off-by: Daniel Mack Signed-off-by: Takashi Iwai