kernel.git/sound/pci/echoaudio, branch linux-4.3.y

ALSA: echoaudio: Use standard C definitions of true and false

2015-08-10T12:27:16Z

The echoaudio locally defines TRUE and FALSE. Not only is this redundant given that C now has a boolean type it results in lots of warnings as other headers also define these macros, causing duplicate definitions. Fix this by removing the local defines and converting all local users to use the standard C true and false instead, simply removing the macros is less safe due to implicit inclusion of the other definitons. [fixed overlooked replacement of FALSE by tiwai] Signed-off-by: Mark Brown Signed-off-by: Takashi Iwai

ALSA: echoaudio: read past end of array

2015-03-23T13:00:28Z

We need to cap "ucontrol->id.index / num_busses_in(chip)" so the we don't read beyond the end of the array. I also adding a check on "in" and changing the type in snd_echo_mixer_put() from short to unsigned int. Those changes are done for symmetry and are cosmetic. Signed-off-by: Dan Carpenter Signed-off-by: Takashi Iwai

ALSA: Include linux/io.h instead of asm/io.h

2015-01-28T15:49:33Z

Nowadays it's recommended. Replace all in a shot. Signed-off-by: Takashi Iwai

ALSA: echoaudio: Use setup_timer() and mod_timer()

2015-01-19T10:33:20Z

No functional change, refactoring with the standard helpers. Signed-off-by: Takashi Iwai

Merge branch 'topic/pci-cleanup' into for-next

2015-01-11T10:26:48Z

ALSA: echoaudio: Simplify PM callbacks

2015-01-09T15:24:20Z

This is a similar cleanup like the commit [3db084fd0af5: ALSA: fm801: PCI core handles power state for us]. Since pci_set_power_state(), pci_save_state() and pci_restore_state() are already done in the PCI core side, so we don't need to it doubly. Also, pci_enable_device(), pci_disable_device() and pci_set_master() calls in PM callbacks are superfluous nowadays, too, so get rid of them as well. Signed-off-by: Takashi Iwai

ALSA: Deletion of checks before the function call "iounmap"

2015-01-04T14:13:45Z

The iounmap() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai

ALSA: echoaudio: Deletion of a check before release_and_free_resource()

2014-12-02T17:40:22Z

The release_and_free_resource() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai

ALSA: echoaudio: cleanup of unnecessary messages

2014-11-05T14:35:57Z

commit "b5b4a41b392960010fccf1f9ccf8334d612bd450" was dereferencing chip after it has been freed. This patch fixes that and at the same time removes some debugging messages, which are unnecessary, as they are just printing information about entry and exit from a function, and which switch-case it is executing. we can easily get from ftrace the information about the entry and exit from a function. Reported-by: Dan Carpenter Signed-off-by: Sudip Mukherjee Signed-off-by: Takashi Iwai

ALSA: echoaudio: remove all snd_printk

2014-11-03T13:07:25Z

removed all references of snd_printk with the standard dev_* macro. [a few places degraded to dev_dbg(), too -- tiwai] Signed-off-by: Sudip Mukherjee Signed-off-by: Takashi Iwai