kernel.git/sound/core/seq/seq_midi.c, branch linux-5.0.y

ALSA: seq: Minor cleanup of MIDI event parser helpers

2018-08-01T20:54:35Z

snd_midi_event_encode_byte() can never fail, and it can return rather true/false. Change the return type to bool, adjust the argument to receive a MIDI byte as unsigned char, and adjust the comment accordingly. This allows callers to drop error checks, which simplifies the code. Meanwhile, snd_midi_event_encode() helper is used only in seq_midi.c, and it can be better folded into it. This will reduce the total amount of lines in the end. Signed-off-by: Takashi Iwai

ALSA: seq: Drop snd_seq_autoload_lock() and _unlock()

2015-02-12T13:42:31Z

The autoload lock became already superfluous due to the recent rework of autoload code. Let's drop them now. This allows us to simplify a few codes nicely. Signed-off-by: Takashi Iwai

ALSA: seq: Define driver object in each driver

2015-02-12T13:15:54Z

This patch moves the driver object initialization and allocation to each driver's module init/exit code like other normal drivers. The snd_seq_driver struct is now published in seq_device.h, and each driver is responsible to define it with proper driver attributes (name, probe and remove) with snd_seq_driver specific attributes as id and argsize fields. The helper functions snd_seq_driver_register(), snd_seq_driver_unregister() and module_snd_seq_driver() are used for simplifying codes. Signed-off-by: Takashi Iwai

ALSA: seq: Deletion of unnecessary checks before the function call "snd_midi_event_free"

2015-01-04T14:11:05Z

The snd_midi_event_free() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai

ALSA: core: Fix format string mismatch in seq_midi.c

2014-04-28T10:18:47Z

Fix format string mismatch in snd_seq_midisynth_register_port(). Argument type of p is unsigned int. Signed-off-by: Masanari Iida Signed-off-by: Takashi Iwai

ALSA: seq: Use standard printk helpers

2014-02-14T07:14:18Z

Use the standard pr_xxx() helpers instead of home-baked snd_print*(). Signed-off-by: Takashi Iwai

sound: fix drivers needing module.h not moduleparam.h

2011-10-31T23:31:19Z

The implicit presence of module.h lured several users into incorrectly thinking that they only needed/used modparam.h but once we clean up the module.h presence, these will show up as build failures, so fix 'em now. Signed-off-by: Paul Gortmaker

sound: rawmidi: disable active-sensing-on-close by default

2009-07-15T09:57:20Z

Sending an Active Sensing message when closing a port can interfere with the following data if the port is reopened and a note-on is sent before the device's timeout has elapsed. Therefore, it is better to disable this setting by default. Signed-off-by: Clemens Ladisch Signed-off-by: Takashi Iwai

sound: seq_midi: do not send MIDI reset when closing

2009-07-15T09:56:58Z

Sending a MIDI reset message when closing a port is wrong because we only want to shut the device up, not to reset all settings. Furthermore, many devices ignore this message. Fortunately, the RawMIDI layer already shuts the device up, so we can ignore this matter here. Signed-off-by: Clemens Ladisch Signed-off-by: Takashi Iwai

seq-midi: always log message on output overrun

2009-07-15T09:56:06Z

It turns out that the main cause of output buffer overruns is not slow drivers but applications that generate too many messages. Therefore, it makes more sense to make that error message always visible, and to rate-limit it. Signed-off-by: Clemens Ladisch Signed-off-by: Takashi Iwai