kernel.git/net/sunrpc/svc.c, branch linux-6.3.y

SUNRPC: Fix trace_svc_register() call site

2023-05-24T16:30:16Z

[ Upstream commit 07a27305938559fb35f7a46fb90a5e37728bdee6 ] The trace event recorded incorrect values for the registered family, protocol, and port because the arguments are in the wrong order. Fixes: b4af59328c25 ("SUNRPC: Trace server-side rpcbind registration events") Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin

SUNRPC: Fix encoding of accepted but unsuccessful RPC replies

2023-05-24T16:30:13Z

[ Upstream commit 29cd2927fb914cc53b5ba4f67d2b74695c994ba4 ] Jiri Slaby says: > I bisected to this ... as it breaks nfs3-only servers in 6.3. > I.e. /etc/nfs.conf containing: > [nfsd] > vers4=no > > The client sees: > mount("10.0.2.15:/tmp", "/mnt", "nfs", 0, "vers=4.2,addr=10.0.2.15,clientad"...) = -1 EIO (Input/output error) > write(2, "mount.nfs: mount system call fai"..., 45 > mount.nfs: mount system call failed for /mnt > > And the kernel says: > nfs4_discover_server_trunking unhandled error -5. Exiting with error EIO Reported-by: Jiri Slaby Link: https://bugzilla.suse.com/show_bug.cgi?id=1210995 Fixes: 4bcf0343e8a6 ("SUNRPC: Set rq_accept_statp inside ->accept methods") Tested-by: Jiri Slaby Signed-off-by: Chuck Lever Signed-off-by: Sasha Levin

SUNRPC: Fix a server shutdown leak

2023-03-08T13:46:41Z

Fix a race where kthread_stop() may prevent the threadfn from ever getting called. If that happens the svc_rqst will not be cleaned up. Fixes: ed6473ddc704 ("NFSv4: Fix callback server shutdown") Signed-off-by: Benjamin Coddington Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever

SUNRPC: Replace pool stats with per-CPU variables

2023-02-20T14:20:32Z

Eliminate the use of bus-locked operations in svc_xprt_enqueue(), which is a hot path. Replace them with per-cpu variables to reduce cross-CPU memory bus traffic. Signed-off-by: Chuck Lever

SUNRPC: Use per-CPU counters to tally server RPC counts

2023-02-20T14:20:32Z

- Improves counting accuracy - Reduces cross-CPU memory traffic Signed-off-by: Chuck Lever

SUNRPC: Set rq_accept_statp inside ->accept methods

2023-02-20T14:20:31Z

To navigate around the space that svcauth_gss_accept() reserves for the RPC payload body length and sequence number fields, svcauth_gss_release() does a little dance with the reply's accept_stat, moving the accept_stat value in the response buffer down by two words. Instead, let's have the ->accept() methods each set the proper final location of the accept_stat to avoid having to move things. Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever

SUNRPC: Refactor RPC server dispatch method

2023-02-20T14:20:31Z

Currently, svcauth_gss_accept() pre-reserves response buffer space for the RPC payload length and GSS sequence number before returning to the dispatcher, which then adds the header's accept_stat field. The problem is the accept_stat field is supposed to go before the length and seq_num fields. So svcauth_gss_release() has to relocate the accept_stat value (see svcauth_gss_prepare_to_wrap()). To enable these fields to be added to the response buffer in the correct (final) order, the pointer to the accept_stat has to be made available to svcauth_gss_accept() so that it can set it before reserving space for the length and seq_num fields. As a first step, move the pointer to the location of the accept_stat field into struct svc_rqst. Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever

SUNRPC: Final clean-up of svc_process_common()

2023-02-20T14:20:31Z

The @resv parameter is no longer used. Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever

SUNRPC: Convert RPC Reply header encoding to use xdr_stream

2023-02-20T14:20:30Z

The main part of RPC header encoding and the formation of error responses are now done using the xdr_stream helpers. Bounds checking before each XDR data item is encoded makes the server's encoding path safer against accidental buffer overflows. Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever

SUNRPC: Hoist init_encode out of svc_authenticate()

2023-02-20T14:20:29Z

Now that each ->accept method has been converted, the svcxdr_init_encode() calls can be hoisted back up into the generic RPC server code. Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever