kernel.git/net/sunrpc/rpc_pipe.c, branch linux-rolling-stable

convert rpc_pipefs

2025-11-18T04:59:27Z

Just use d_make_persistent() + dput() (and fold the latter into simple_finish_creating()) and that's it... NOTE: pipe->dentry is a borrowed reference - it does not contribute to dentry refcount. Signed-off-by: Al Viro

Merge tag 'pull-rpc_pipefs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs

2025-07-28T16:56:09Z

Pull rpc_pipefs updates from Al Viro: "Massage rpc_pipefs to use saner primitives and clean up the APIs provided to the rest of the kernel" * tag 'pull-rpc_pipefs' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs: rpc_create_client_dir(): return 0 or -E... rpc_create_client_dir(): don't bother with rpc_populate() rpc_new_dir(): the last argument is always NULL rpc_pipe: expand the calls of rpc_mkdir_populate() rpc_gssd_dummy_populate(): don't bother with rpc_populate() rpc_mkpipe_dentry(): switch to simple_start_creating() rpc_pipe: saner primitive for creating regular files rpc_pipe: saner primitive for creating subdirectories rpc_pipe: don't overdo directory locking rpc_mkpipe_dentry(): saner calling conventions rpc_unlink(): saner calling conventions rpc_populate(): lift cleanup into callers rpc_unlink(): use simple_recursive_removal() rpc_{rmdir_,}depopulate(): use simple_recursive_removal() instead rpc_pipe: clean failure exits in fill_super new helper: simple_start_creating()

rpc_create_client_dir(): return 0 or -E...

2025-07-03T02:44:55Z

Callers couldn't care less which dentry did we get - anything valid is treated as success. Reviewed-by: Jeff Layton Signed-off-by: Al Viro

rpc_create_client_dir(): don't bother with rpc_populate()

2025-07-03T02:44:55Z

not for a single file... Reviewed-by: Jeff Layton Signed-off-by: Al Viro

rpc_new_dir(): the last argument is always NULL

2025-07-03T02:44:55Z

All callers except the one in rpc_populate() pass explicit NULL there; rpc_populate() passes its last argument ('private') instead, but in the only call of rpc_populate() that creates any subdirectories (when creating fixed subdirectories of root) private itself is NULL. Reviewed-by: Jeff Layton Signed-off-by: Al Viro

rpc_pipe: expand the calls of rpc_mkdir_populate()

2025-07-03T02:44:55Z

... and get rid of convoluted callbacks. Reviewed-by: Jeff Layton Signed-off-by: Al Viro

rpc_gssd_dummy_populate(): don't bother with rpc_populate()

2025-07-03T02:44:55Z

Just have it create gssd (in root), clntXX in gssd, then info and gssd in clntXX - all with explicit rpc_new_dir()/rpc_new_file()/rpc_mkpipe_dentry(). Reviewed-by: Jeff Layton Signed-off-by: Al Viro

rpc_mkpipe_dentry(): switch to simple_start_creating()

2025-07-03T02:44:55Z

... and make sure we set the fs-private part of inode up before attaching it to dentry. Reviewed-by: Jeff Layton Signed-off-by: Al Viro

rpc_pipe: saner primitive for creating regular files

2025-07-03T02:44:55Z

rpc_new_file(); similar to rpc_new_dir(), except that here we pass file_operations as well. Callers don't care about dentry, just return 0 or -E... Reviewed-by: Jeff Layton Signed-off-by: Al Viro

rpc_pipe: saner primitive for creating subdirectories

2025-07-03T02:44:55Z

All users of __rpc_mkdir() have the same form - start_creating(), followed, in case of success, by __rpc_mkdir() and unlocking parent. Combine that into a single helper, expanding __rpc_mkdir() into it, along with the call of __rpc_create_common() in it. Don't mess with d_drop() + d_add() - just d_instantiate() and be done with that. The reason __rpc_create_common() goes for that dance is that dentry it gets might or might not be hashed; here we know it's hashed. Reviewed-by: Jeff Layton Signed-off-by: Al Viro