kernel.git/net/nfc/nci, branch linux-4.5.y

NFC: nci: memory leak in nci_core_conn_create()

2015-12-29T18:06:23Z

I've moved the check for "number_destination_params" forward a few lines to avoid leaking "cmd". Fixes: caa575a86ec1 ('NFC: nci: fix possible crash in nci_core_conn_create') Acked-by: Christophe Ricard Signed-off-by: Dan Carpenter Signed-off-by: Samuel Ortiz

NFC: nci: Fix error check of nci_hci_create_pipe() result

2015-12-29T18:06:18Z

net/nfc/nci/hci.c: In function nci_hci_connect_gate : net/nfc/nci/hci.c:679: warning: comparison is always false due to limited range of data type In case of error, nci_hci_create_pipe() returns NCI_HCI_INVALID_PIPE, and not a negative error code. Correct the check to fix this. Acked-by: Geert Uytterhoeven Reported-by: Dan Carpenter Signed-off-by: Christophe Ricard Signed-off-by: Samuel Ortiz

NFC: nci: non-static functions can not be inline

2015-10-28T05:44:45Z

This fixes a build error that seems to be toochain dependent (Not seen with gcc v5.1): In file included from net/nfc/nci/rsp.c:36:0: net/nfc/nci/rsp.c: In function ‘nci_rsp_packet’: include/net/nfc/nci_core.h:355:12: error: inlining failed in call to always_inline ‘nci_prop_rsp_packet’: function body not available inline int nci_prop_rsp_packet(struct nci_dev *ndev, __u16 opcode, Signed-off-by: Robert Dolca Signed-off-by: Samuel Ortiz

NFC: NCI: allow spi driver to choose transfer clock

2015-10-27T03:23:34Z

In some cases low level drivers might want to update the SPI transfer clock (e.g. during firmware download). This patch adds this support. Without any modification the driver will use the default SPI clock (from pdata or device tree). Signed-off-by: Vincent Cuissard Signed-off-by: Samuel Ortiz

NFC: NCI: move generic spi driver to a module

2015-10-27T03:21:38Z

SPI driver should be a module. Signed-off-by: Vincent Cuissard Signed-off-by: Samuel Ortiz

NFC: NCI: export nci_send_frame and nci_send_cmd function

2015-10-27T03:16:14Z

Export nci_send_frame and nci_send_cmd symbols to allow drivers to use it. This is needed for example if NCI is used during firmware download phase. Signed-off-by: Vincent Cuissard Signed-off-by: Samuel Ortiz

NFC: st-nci: Add few code style fixes

2015-10-27T02:55:13Z

Add some few code style fixes. Signed-off-by: Christophe Ricard Signed-off-by: Samuel Ortiz

NFC: netlink: Add mode parameter to deactivate_target functions

2015-10-27T02:55:12Z

In order to manage in a better way the nci poll mode state machine, add mode parameter to deactivate_target functions. This way we can manage different target state. mode parameter make sense only in nci core. Signed-off-by: Christophe Ricard Signed-off-by: Samuel Ortiz

NFC: nci: Create pipe on specific gate in nci_hci_connect_gate

2015-10-26T05:53:13Z

Some gates might need to have their pipes explicitly created. Add a call to nci_hci_create_pipe in nci_hci_connect_gate for every gate that is different than NCI_HCI_LINK_MGMT_GATE or NCI_HCI_ADMIN_GATE. In case of an error when opening a pipe, like in hci layer, delete the pipe if it was created. Signed-off-by: Christophe Ricard Signed-off-by: Samuel Ortiz

NFC: nci: Call nci_hci_clear_all_pipes at HCI initial activation.

2015-10-26T05:53:13Z

When session_id is filled to 0xff, the pipe configuration is probably incorrect and needs to be cleared. Signed-off-by: Christophe Ricard Signed-off-by: Samuel Ortiz