kernel.git/net/dccp/ipv4.c, branch linux-2.6.27.y

dccp: Fix incorrect length check for ICMPv4 packets

2008-07-26T10:59:10Z

Unlike TCP, which only needs 8 octets of original packet data, DCCP requires minimally 12 or 16 bytes for ICMP-payload sequence number checks. This patch replaces the insufficient length constant of 8 with a two-stage test, making sure that 12 bytes are available, before computing the basic header length required for sequence number checks. Signed-off-by: Wei Yongjun Signed-off-by: Gerrit Renker

dccp: Fix sequence number check for ICMPv4 packets

2008-07-26T10:59:10Z

The payload of ICMP message is a part of the packet sent by ourself, so the sequence number check must use AWL and AWH, not SWL and SWH. For example: Endpoint A Endpoint B DATA-ACK --------> (SEQ=X) <-------- ICMP (Fragmentation Needed) (SEQ=X) Signed-off-by: Wei Yongjun Acked-by: Gerrit Renker

net: convert BUG_TRAP to generic WARN_ON

2008-07-26T04:43:18Z

Removes legacy reinvent-the-wheel type thing. The generic machinery integrates much better to automated debugging aids such as kerneloops.org (and others), and is unambiguous due to better naming. Non-intuively BUG_TRAP() is actually equal to WARN_ON() rather than BUG_ON() though some might actually be promoted to BUG_ON() but I left that to future. I could make at least one BUILD_BUG_ON conversion. Signed-off-by: Ilpo Järvinen Signed-off-by: David S. Miller

mib: add net to NET_INC_STATS_BH

2008-07-17T03:31:16Z

Signed-off-by: Pavel Emelyanov Signed-off-by: David S. Miller

mib: add net to IP_INC_STATS_BH

2008-07-17T03:20:11Z

Signed-off-by: Pavel Emelyanov Signed-off-by: David S. Miller

mib: add struct net to ICMP_INC_STATS_BH

2008-07-15T06:05:29Z

Signed-off-by: Pavel Emelyanov Signed-off-by: David S. Miller

inet: toss struct net initialization around

2008-07-15T06:05:26Z

Some places, that deal with ICMP statistics already have where to get a struct net from, but use it directly, without declaring a separate variable on the stack. Since I will need this net soon, I declare a struct net on the stack and use it in the existing places in a separate patch not to spoil the future ones. Signed-off-by: Pavel Emelyanov Signed-off-by: David S. Miller

inet{6}_request_sock: Init ->opt and ->pktopts in the constructor

2008-06-10T19:39:35Z

Wei Yongjun noticed that we may call reqsk_free on request sock objects where the opt fields may not be initialized, fix it by introducing inet_reqsk_alloc where we initialize ->opt to NULL and set ->pktopts to NULL in inet6_reqsk_alloc. Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: David S. Miller

dccp: Fix to handle short sequence numbers packet correctly

2008-05-27T13:22:38Z

RFC4340 said: 8.5. Pseudocode ... If P.type is not Data, Ack, or DataAck and P.X == 0 (the packet has short sequence numbers), drop packet and return But DCCP has some mistake to handle short sequence numbers packet, now it drop packet only if P.type is Data, Ack, or DataAck and P.X == 0. Signed-off-by: Wei Yongjun Acked-by: Gerrit Renker Acked-by: Arnaldo Carvalho de Melo Signed-off-by: David S. Miller

[DCCP]: Fix comment about control sockets.

2008-04-14T09:38:45Z

These sockets now have a bit other names and are no longer global. Shame on me, I haven't provided a good comment for this when sending DCCP netnsization patches. Signed-off-by: Pavel Emelyanov Signed-off-by: David S. Miller