kernel.git/kernel/irq/manage.c, branch linux-6.16.yHosts the 0x221E linux distro kernel.
https://git.0xinfinity.dev/distro/kernel.git/atom?h=linux-6.16.y2025-05-14T10:05:58Zgenirq/manage: Use the correct lock guard in irq_set_irq_wake()2025-05-14T10:05:58ZJon Hunter2025-05-14T09:50:41Zurn:sha1:58eb5721a445ea0af310d1410d7117a1910627bc
Commit 8589e325ba4f ("genirq/manage: Rework irq_set_irq_wake()") updated
the irq_set_irq_wake() to use the new guards for locking the interrupt
descriptor.
However, in doing so it inadvertently changed irq_set_irq_wake() such that
the 'chip_bus_lock' is no longer acquired. This has caused system suspend
tests to fail on some Tegra platforms.
Fix this by correcting the guard used in irq_set_irq_wake() to ensure the
'chip_bus_lock' is held.
Fixes: 8589e325ba4f ("genirq/manage: Rework irq_set_irq_wake()")
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250514095041.1109783-1-jonathanh@nvidia.com
genirq: Use scoped_guard() to shut clang up2025-05-07T15:08:44ZThomas Gleixner2025-05-07T13:47:06Zurn:sha1:97f4b999e0c894d3e48e318aa1130132031815b3
This code pattern trips clang up:
if (fail)
goto undo;
guard(lock)(lock);
do_stuff();
return 0;
undo:
...
as it somehow extends the scope of the guard beyond the return statement.
Replace it with a scoped guard to help it to get its act together.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Closes: https://lore.kernel.org/oe-kbuild-all/202505071809.ajpPxfoZ-lkp@intel.com/
genirq: Remove unused remove_percpu_irq()2025-05-07T09:35:41ZDr. David Alan Gilbert2025-04-20T16:46:56Zurn:sha1:aefc11550ebd08eadee6d643792c9092de2e472f
remove_percpu_irq() has been unused since it was added in 2011 by
commit 31d9d9b6d830 ("genirq: Add support for per-cpu dev_id interrupts")
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250420164656.112641-1-linux@treblig.org
genirq/manage: Rework irq_set_irqchip_state()2025-05-07T07:08:16ZThomas Gleixner2025-04-29T06:55:53Zurn:sha1:193879e28be7bb26abc795e6b5096ef9fe3131cf
Use the new guards to get and lock the interrupt descriptor and tidy up the
code.
No functional change.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065422.670808288@linutronix.de
genirq/manage: Rework irq_get_irqchip_state()2025-05-07T07:08:16ZThomas Gleixner2025-04-29T06:55:52Zurn:sha1:782249a997472acec7e8d8f04177750192712a19
Use the new guards to get and lock the interrupt descriptor and tidy up the
code.
No functional change.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065422.612184618@linutronix.de
genirq/manage: Rework teardown_percpu_nmi()2025-05-07T07:08:16ZThomas Gleixner2025-04-29T06:55:50Zurn:sha1:5fec6d5cd24a35f5b03612dd02975e3be1b788b8
Use the new guards to get and lock the interrupt descriptor and tidy up the
code.
No functional change.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065422.552884529@linutronix.de
genirq/manage: Rework prepare_percpu_nmi()2025-05-07T07:08:16ZThomas Gleixner2025-04-29T06:55:49Zurn:sha1:65dd1f7ca94fde615684827af285a0475d177b9a
Use the new guards to get and lock the interrupt descriptor and tidy up the
code.
No functional change.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065422.494561120@linutronix.de
genirq/manage: Rework disable_percpu_irq()2025-05-07T07:08:16ZThomas Gleixner2025-04-29T06:55:47Zurn:sha1:8e3f672b1949d58462e23abdc41c039a82e685fd
Use the new guards to get and lock the interrupt descriptor and tidy up the
code.
No functional change.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065422.435932527@linutronix.de
genirq/manage: Rework irq_percpu_is_enabled()2025-05-07T07:08:16ZThomas Gleixner2025-04-29T06:55:46Zurn:sha1:b171f712d6ef1ae073d18e8ea9df1e96eb34f226
Use the new guards to get and lock the interrupt descriptor and tidy up the
code.
No functional change.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065422.376836282@linutronix.de
genirq/manage: Rework enable_percpu_irq()2025-05-07T07:08:16ZThomas Gleixner2025-04-29T06:55:44Zurn:sha1:508bd94c3ad4bd8b5dba8280198ce1eb31eb625a
Use the new guards to get and lock the interrupt descriptor and tidy up the
code.
No functional change.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065422.315844964@linutronix.de