kernel.git/fs/nfsd/filecache.c, branch linux-5.4.y

nfsd: Containerise filecache laundrette

2022-03-28T06:46:43Z

commit 9542e6a643fc69d528dfb3303f145719c61d3050 upstream. Ensure that if the filecache laundrette gets stuck, it only affects the knfsd instances of one container. The notifier callbacks can be called from various contexts so avoid using synchonous filesystem operations that might deadlock. Signed-off-by: Trond Myklebust Signed-off-by: J. Bruce Fields Cc: Khazhy Kumykov Signed-off-by: Greg Kroah-Hartman

nfsd: cleanup nfsd_file_lru_dispose()

2022-03-28T06:46:43Z

commit 36ebbdb96b694dd9c6b25ad98f2bbd263d022b63 upstream. Signed-off-by: Trond Myklebust Signed-off-by: J. Bruce Fields Cc: Khazhy Kumykov Signed-off-by: Greg Kroah-Hartman

nfsd: Don't keep looking up unhashed files in the nfsd file cache

2021-03-24T10:26:38Z

commit d30881f573e565ebb5dbb50b31ed6106b5c81328 upstream. If a file is unhashed, then we're going to reject it anyway and retry, so make sure we skip it when we're doing the RCU lockless lookup. This avoids a number of unnecessary nfserr_jukebox returns from nfsd_file_acquire() Fixes: 65294c1f2c5e ("nfsd: add a new struct file caching facility to nfsd") Signed-off-by: Trond Myklebust Signed-off-by: Chuck Lever Signed-off-by: Greg Kroah-Hartman

nfsd: Fix a soft lockup race in nfsd_file_mark_find_or_create()

2020-10-01T11:17:28Z

[ Upstream commit 90d2f1da832fd23290ef0c0d964d97501e5e8553 ] If nfsd_file_mark_find_or_create() keeps winning the race for the nfsd_file_fsnotify_group->mark_mutex against nfsd_file_mark_put() then it can soft lock up, since fsnotify_add_inode_mark() ends up always finding an existing entry. Signed-off-by: Trond Myklebust Signed-off-by: J. Bruce Fields Signed-off-by: Sasha Levin

nfsd: fix filecache lookup

2020-02-11T12:35:32Z

commit 28c7d86bb6172ffbb1a1237c6388e77f9fe5f181 upstream. If the lookup keeps finding a nfsd_file with an unhashed open file, then retry once only. Signed-off-by: Trond Myklebust Cc: stable@vger.kernel.org Fixes: 65294c1f2c5e "nfsd: add a new struct file caching facility to nfsd" Signed-off-by: J. Bruce Fields Signed-off-by: Greg Kroah-Hartman

nfsd: Don't garbage collect files that might contain write errors

2019-09-10T13:23:41Z

If a file may contain unstable writes that can error out, then we want to avoid garbage collecting the struct nfsd_file that may be tracking those errors. So in the garbage collector, we try to avoid collecting files that aren't clean. Furthermore, we avoid immediately kicking off the garbage collector in the case where the reference drops to zero for the case where there is a write error that is being tracked. If the file is unhashed while an error is pending, then declare a reboot, to ensure the client resends any unstable writes. Signed-off-by: Trond Myklebust Signed-off-by: J. Bruce Fields

nfsd: nfsd_file cache entries should be per net namespace

2019-09-10T13:23:41Z

Ensure that we can safely clear out the file cache entries when the nfs server is shut down on a container. Otherwise, the file cache may end up pinning the mounts. Signed-off-by: Trond Myklebust Signed-off-by: J. Bruce Fields

nfsd: remove duplicated include from filecache.c

2019-08-20T15:15:34Z

Remove duplicated include. Signed-off-by: YueHaibing Signed-off-by: J. Bruce Fields

nfsd: add a new struct file caching facility to nfsd

2019-08-19T15:00:39Z

Currently, NFSv2/3 reads and writes have to open a file, do the read or write and then close it again for each RPC. This is highly inefficient, especially when the underlying filesystem has a relatively slow open routine. This patch adds a new open file cache to knfsd. Rather than doing an open for each RPC, the read/write handlers can call into this cache to see if there is one already there for the correct filehandle and NFS_MAY_READ/WRITE flags. If there isn't an entry, then we create a new one and attempt to perform the open. If there is, then we wait until the entry is fully instantiated and return it if it is at the end of the wait. If it's not, then we attempt to take over construction. Since the main goal is to speed up NFSv2/3 I/O, we don't want to close these files on last put of these objects. We need to keep them around for a little while since we never know when the next READ/WRITE will come in. Cache entries have a hardcoded 1s timeout, and we have a recurring workqueue job that walks the cache and purges any entries that have expired. Signed-off-by: Jeff Layton Signed-off-by: Weston Andros Adamson Signed-off-by: Richard Sharpe Signed-off-by: Trond Myklebust Signed-off-by: Trond Myklebust Signed-off-by: J. Bruce Fields