kernel.git/fs/nfsd/export.c, branch linux-3.16.y

NFSD: Error out when getting more than one fsloc/secinfo/uuid

2014-05-30T21:32:25Z

Signed-off-by: Kinglong Mee Signed-off-by: J. Bruce Fields

NFSD: Using type of uint32_t for ex_nflavors instead of int

2014-05-30T21:32:24Z

ex_nflavors can't be negative number, just defined by uint32_t. Signed-off-by: Kinglong Mee Signed-off-by: J. Bruce Fields

NFSD: Add missing comment of "expiry" in expkey_parse()

2014-05-30T21:32:24Z

Signed-off-by: Kinglong Mee Signed-off-by: J. Bruce Fields

NFSD: Remove typedef of svc_client and svc_export in export.c

2014-05-30T21:32:23Z

No need for a typedef wrapper for svc_export or svc_client, remove them. Signed-off-by: Kinglong Mee Signed-off-by: J. Bruce Fields

NFSD: Cleanup unneeded including net/ipv6.h

2014-05-30T21:32:22Z

Commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code") removed the only use of ipv6_addr_set_v4mapped(), so net/ipv6.h is unneeded now. Signed-off-by: Kinglong Mee Signed-off-by: J. Bruce Fields

NFSD: Adds macro EX_UUID_LEN for exports uuid's length

2014-05-30T21:32:19Z

Signed-off-by: Kinglong Mee Signed-off-by: J. Bruce Fields

NFSD: Helper function for parsing uuid

2014-05-30T21:32:19Z

Signed-off-by: Kinglong Mee Signed-off-by: J. Bruce Fields

NFS4: Avoid NULL reference or double free in nfsd4_fslocs_free()

2014-05-30T21:32:18Z

If fsloc_parse() failed at kzalloc(), fs/nfsd/export.c 411 412 fsloc->locations = kzalloc(fsloc->locations_count 413 * sizeof(struct nfsd4_fs_location), GFP_KERNEL); 414 if (!fsloc->locations) 415 return -ENOMEM; svc_export_parse() will call nfsd4_fslocs_free() with fsloc->locations = NULL, so that, "kfree(fsloc->locations[i].path);" will cause a crash. If fsloc_parse() failed after that, fsloc_parse() will call nfsd4_fslocs_free(), and svc_export_parse() will call it again, so that, a double free is caused. This patch checks the fsloc->locations, and set to NULL after it be freed. Signed-off-by: Kinglong Mee Signed-off-by: J. Bruce Fields

nfsd: -EINVAL on invalid anonuid/gid instead of silent failure

2013-10-29T21:46:14Z

If we're going to refuse to accept these it would be polite of us to at least say so.... This introduces a slight complication since we need to grandfather in exportfs's ill-advised use of -1 uid and gid on its test_export. If it turns out there are other users passing down -1 we may need to do something else. Best might be to drop the checks entirely, but I'm not sure if other parts of the kernel might assume that a task can't run as uid or gid -1. Cc: "Eric W. Biederman" Signed-off-by: J. Bruce Fields

nfsd: return better errors to exportfs

2013-10-29T21:45:30Z

Someone noticed exportfs happily accepted exports that would later be rejected when mountd tried to give them to the kernel. Fix this. This is a regression from 4c1e1b34d5c800ad3ac9a7e2805b0bea70ad2278 "nfsd: Store ex_anon_uid and ex_anon_gid as kuids and kgids". Cc: "Eric W. Biederman" Cc: stable@vger.kernel.org Reported-by: Yin.JianHong Signed-off-by: J. Bruce Fields