kernel.git/fs/nfs/nfs4filelayoutdev.c, branch linux-3.12.y

NFSv4.1: nfs4_fl_prepare_ds must be careful about reporting success.

2017-01-26T16:40:47Z

commit cfd278c280f997cf2fe4662e0acab0fe465f637b upstream. Various places assume that if nfs4_fl_prepare_ds() turns a non-NULL 'ds', then ds->ds_clp will also be non-NULL. This is not necessasrily true in the case when the process received a fatal signal while nfs4_pnfs_ds_connect is waiting in nfs4_wait_ds_connect(). In that case ->ds_clp may not be set, and the devid may not recently have been marked unavailable. So add a test for ds_clp == NULL and return NULL in that case. Fixes: c23266d532b4 ("NFS4.1 Fix data server connection race") Signed-off-by: NeilBrown Acked-by: Olga Kornievskaia Acked-by: Adamson, Andy Signed-off-by: Trond Myklebust Signed-off-by: Jiri Slaby

nfs: fix dead code of ipv6_addr_scope

2014-04-03T08:32:14Z

commit a8c2275493b866961f4429a741251c630c4fc6d7 upstream. The correct way to check on IPV6_ADDR_SCOPE_LINKLOCAL is to check with the ipv6_addr_src_scope function. Currently this can't be work, because ipv6_addr_scope returns a int with a mask of IPV6_ADDR_SCOPE_MASK (0x00f0U) and IPV6_ADDR_SCOPE_LINKLOCAL is 0x02. So the condition is always false. Signed-off-by: Alexander Aring Signed-off-by: Trond Myklebust Signed-off-by: Jiri Slaby

NFSv4.1: Ensure memory ordering between nfs4_ds_connect and nfs4_fl_prepare_ds

2013-09-29T19:58:35Z

We need to ensure that the initialisation of the data server nfs_client structure in nfs4_ds_connect is correctly ordered w.r.t. the read of ds->ds_clp in nfs4_fl_prepare_ds. Signed-off-by: Trond Myklebust

NFSv4.1: nfs4_fl_prepare_ds - fix bugs when the connect attempt fails

2013-09-29T19:56:35Z

- Fix an Oops when nfs4_ds_connect() returns an error. - Always check the device status after waiting for a connect to complete. Reported-by: Andy Adamson Reported-by: Jeff Layton Signed-off-by: Trond Myklebust Cc: # v3.10+

NFSv4.1 Fix gdia_maxcount calculation to fit in ca_maxresponsesize

2013-06-28T19:34:43Z

The GETDEVICEINFO gdia_maxcount represents all of the data being returned within the GETDEVICEINFO4resok structure and includes the XDR overhead. The CREATE_SESSION ca_maxresponsesize is the maximum reply and includes the RPC headers (including security flavor credentials and verifiers). Split out the struct pnfs_device field maxcount which is the gdia_maxcount from the pglen field which is the reply (the total) buffer length. Signed-off-by: Andy Adamson Signed-off-by: Trond Myklebust

NFSv4.1: Use layout credentials for get_deviceinfo calls

2013-06-06T20:24:37Z

This is not strictly needed, since get_deviceinfo is not allowed to return NFS4ERR_ACCESS or NFS4ERR_WRONG_CRED, but lets do it anyway for consistency with other pNFS operations. Signed-off-by: Trond Myklebust

NFS4.1 Fix data server connection race

2013-05-08T21:19:32Z

Unlike meta data server mounts which support multiple mount points to the same server via struct nfs_server, data servers support a single connection. Concurrent calls to setup the data server connection can race where the first call allocates the nfs_client struct, and before the cache struct nfs_client pointer can be set, a second call also tries to setup the connection, finds the already allocated nfs_client, bumps the reference count, re-initializes the session,etc. This results in a hanging data server session after umount. Signed-off-by: Andy Adamson Signed-off-by: Trond Myklebust

sunrpc: move address copy/cmp/convert routines and prototypes from clnt.h to addr.h

2013-02-05T14:41:14Z

These routines are used by server and client code, so having them in a separate header would be best. Signed-off-by: Jeff Layton Acked-by: Trond Myklebust Signed-off-by: J. Bruce Fields

NFSv4.1: Cleanup move session slot management to fs/nfs/nfs4session.c

2012-12-05T23:30:45Z

NFSv4.1 session management is getting complex enough to deserve a separate file. Signed-off-by: Trond Myklebust

NFSv4.1: Remove assertion BUG_ON()s from the files and generic layout code

2012-11-04T19:43:39Z

Signed-off-by: Trond Myklebust