kernel.git/fs/nfs/export.c, branch linux-5.16.y

NFS: Remove the nfs4_label argument from nfs_fhget()

2021-11-05T18:54:40Z

Signed-off-by: Anna Schumaker Signed-off-by: Trond Myklebust

NFS: Remove the nfs4_label from the nfs4_getattr_res

2021-11-05T18:54:39Z

Signed-off-by: Anna Schumaker Signed-off-by: Trond Myklebust

NFS: Remove the nfs4_label from the nfs4_lookupp_res struct

2021-11-05T18:54:39Z

Signed-off-by: Anna Schumaker Signed-off-by: Trond Myklebust

nfs: don't atempt blocking locks on nfs reexports

2021-08-26T19:32:10Z

NFS implements blocking locks by blocking inside its lock method. In the reexport case, this blocks the nfs server thread, which could lead to deadlocks since an nfs server thread might be required to unlock the conflicting lock. It also causes a crash, since the nfs server thread assumes it can free the lock when its lm_notify lock callback is called. Ideal would be to make the nfs lock method return without blocking in this case, but for now it works just not to attempt blocking locks. The difference is just that the original client will have to poll (as it does in the v4.0 case) instead of getting a callback when the lock's available. Signed-off-by: J. Bruce Fields Acked-by: Anna Schumaker Signed-off-by: Chuck Lever

NFS: Add a cache validity flag argument to nfs_revalidate_inode()

2021-04-13T00:11:44Z

Add an argument to nfs_revalidate_inode() to allow callers to specify which attributes they need to check for validity. Signed-off-by: Trond Myklebust

NFS: fix nfs_fetch_iversion()

2021-04-05T13:04:21Z

The change attribute is always set by all NFS client versions so get rid of the open-coded version. Fixes: 3cc55f4434b4 ("nfs: use change attribute for NFS re-exports") Signed-off-by: Trond Myklebust

nfs: use change attribute for NFS re-exports

2021-01-30T16:47:12Z

When exporting NFS, we may as well use the real change attribute returned by the original server instead of faking up a change attribute from the ctime. Note we can't do that by setting I_VERSION--that would also turn on the logic in iversion.h which treats the lower bit specially, and that doesn't make sense for NFS. So instead we define a new export operation for filesystems like NFS that want to manage the change attribute themselves. Signed-off-by: J. Bruce Fields Reviewed-by: Christoph Hellwig Signed-off-by: Chuck Lever

nfsd: Record NFSv4 pre/post-op attributes as non-atomic

2020-12-09T14:39:38Z

For the case of NFSv4, specify to the client that the pre/post-op attributes were not recorded atomically with the main operation. Signed-off-by: Trond Myklebust Signed-off-by: Chuck Lever

nfsd: Set PF_LOCAL_THROTTLE on local filesystems only

2020-12-09T14:39:38Z

Don't set PF_LOCAL_THROTTLE on remote filesystems like NFS, since they aren't expected to ever be subject to double buffering. Signed-off-by: Trond Myklebust Signed-off-by: Chuck Lever

nfsd: close cached files prior to a REMOVE or RENAME that would replace target

2020-12-09T14:39:38Z

It's not uncommon for some workloads to do a bunch of I/O to a file and delete it just afterward. If knfsd has a cached open file however, then the file may still be open when the dentry is unlinked. If the underlying filesystem is nfs, then that could trigger it to do a sillyrename. On a REMOVE or RENAME scan the nfsd_file cache for open files that correspond to the inode, and proactively unhash and put their references. This should prevent any delete-on-last-close activity from occurring, solely due to knfsd's open file cache. This must be done synchronously though so we use the variants that call flush_delayed_fput. There are deadlock possibilities if you call flush_delayed_fput while holding locks, however. In the case of nfsd_rename, we don't even do the lookups of the dentries to be renamed until we've locked for rename. Once we've figured out what the target dentry is for a rename, check to see whether there are cached open files associated with it. If there are, then unwind all of the locking, close them all, and then reattempt the rename. None of this is really necessary for "typical" filesystems though. It's mostly of use for NFS, so declare a new export op flag and use that to determine whether to close the files beforehand. Signed-off-by: Jeff Layton Signed-off-by: Lance Shelton Signed-off-by: Trond Myklebust Signed-off-by: Chuck Lever