kernel.git/fs/nfs/dir.c, branch linux-2.6.37.y

NFS: Fix NFSv3 exclusive open semantics

2011-02-17T23:14:13Z

commit 8a0eebf66e3b1deae036553ba641a9c2bdbae678 upstream. Commit c0204fd2b8fe047b18b67e07e1bf2a03691240cd (NFS: Clean up nfs4_proc_create()) broke NFSv3 exclusive open by removing the code that passes the O_EXCL flag down to nfs3_proc_create(). This patch reverts that offending hunk from the original commit. Reported-by: Nick Bowler Signed-off-by: Trond Myklebust Tested-by: Nick Bowler Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman

NFS: Don't use vm_map_ram() in readdir

2011-02-17T23:14:13Z

commit 6650239a4b01077e80d5a4468562756d77afaa59 upstream. vm_map_ram() is not available on NOMMU platforms, and causes trouble on incoherrent architectures such as ARM when we access the page data through both the direct and the virtual mapping. The alternative is to use the direct mapping to access page data for the case when we are not crossing a page boundary, but to copy the data into a linear scratch buffer when we are accessing data that spans page boundaries. Signed-off-by: Trond Myklebust Tested-by: Marc Kleine-Budde Signed-off-by: Greg Kroah-Hartman

NFS: Readdir cleanups

2010-12-07T19:09:02Z

No functional changes, but clarify the code. Signed-off-by: Trond Myklebust

NFS: nfs_readdir_search_for_cookie() don't mark as eof if cookie not found

2010-12-07T17:41:58Z

If we're searching for a specific cookie, and it isn't found in the page cache, we should try an uncached_readdir(). To do so, we return EBADCOOKIE, but we don't set desc->eof. Signed-off-by: Trond Myklebust

NFS: Fix a memory leak in nfs_readdir

2010-12-02T14:58:00Z

We need to ensure that the entries in the nfs_cache_array get cleared when the page is removed from the page cache. To do so, we use the freepage address_space operation. Change nfs_readdir_clear_array to use kmap_atomic(), so that the function can be safely called from all contexts. Finally, modify the cache_page_release helper to call nfs_readdir_clear_array directly, when dealing with an anonymous page from 'uncached_readdir'. Signed-off-by: Trond Myklebust

NFS: Ensure we use the correct cookie in nfs_readdir_xdr_filler

2010-12-01T13:16:16Z

We need to use the cookie from the previous array entry, not the actual cookie that we are searching for (except for the case of uncached_readdir). Signed-off-by: Trond Myklebust

NFS: Fix a readdirplus bug

2010-11-30T18:18:49Z

When comparing filehandles in the helper nfs_same_file(), we should not be using 'strncmp()': filehandles are not null terminated strings. Instead, we should just use the existing helper nfs_compare_fh(). Signed-off-by: Trond Myklebust Signed-off-by: Linus Torvalds

NFS: Ensure we return the dirent->d_type when it is known

2010-11-22T18:24:48Z

Store the dirent->d_type in the struct nfs_cache_array_entry so that we can use it in getdents() calls. This fixes a regression with the new readdir code. Signed-off-by: Trond Myklebust

NFS: Correct the array bound calculation in nfs_readdir_add_to_array

2010-11-22T18:24:47Z

It looks as if the array size calculation in MAX_READDIR_ARRAY does not take the alignment of struct nfs_cache_array_entry into account. Signed-off-by: Trond Myklebust

NFS: Don't ignore errors from nfs_do_filldir()

2010-11-22T18:24:47Z

We should ignore the errors from the filldir callback, and just interpret them as meaning we should exit, however we should definitely pass back ENOMEM errors. Signed-off-by: Trond Myklebust