kernel.git/fs/jbd2/transaction.c, branch linux-2.6.28.y

jbd2: Avoid possible NULL dereference in jbd2_journal_begin_ordered_truncate()

2009-03-17T00:32:33Z

(cherry picked from commit 7f5aa215088b817add9c71914b83650bdd49f8a9) If we race with commit code setting i_transaction to NULL, we could possibly dereference it. Proper locking requires the journal pointer (to access journal->j_list_lock), which we don't have. So we have to change the prototype of the function so that filesystem passes us the journal pointer. Also add a more detailed comment about why the function jbd2_journal_begin_ordered_truncate() does what it does and how it should be used. Thanks to Dan Carpenter for pointing to the suspitious code. Signed-off-by: Jan Kara Signed-off-by: "Theodore Ts'o" Acked-by: Joel Becker CC: linux-ext4@vger.kernel.org CC: ocfs2-devel@oss.oracle.com CC: mfasheh@suse.de CC: Dan Carpenter Signed-off-by: Greg Kroah-Hartman

ext4: Replace hackish ext4_mb_poll_new_transaction with commit callback

2008-10-17T00:00:24Z

The multiblock allocator needs to be able to release blocks (and issue a blkdev discard request) when the transaction which freed those blocks is committed. Previously this was done via a polling mechanism when blocks are allocated or freed. A much better way of doing things is to create a jbd2 callback function and attaching the list of blocks to be freed directly to the transaction structure. Signed-off-by: "Theodore Ts'o"

lockdep: rename map_[acquire|release]() => lock_map_[acquire|release]()

2008-08-11T08:30:30Z

the names were too generic: drivers/uio/uio.c:87: error: expected identifier or '(' before 'do' drivers/uio/uio.c:87: error: expected identifier or '(' before 'while' drivers/uio/uio.c:113: error: 'map_release' undeclared here (not in a function) Signed-off-by: Ingo Molnar

lockdep: map_acquire

2008-08-11T07:30:23Z

Most the free-standing lock_acquire() usages look remarkably similar, sweep them into a new helper. Signed-off-by: Peter Zijlstra Signed-off-by: Ingo Molnar

jbd2: Remove data=ordered mode support using jbd buffer heads

2008-07-11T23:27:31Z

Signed-off-by: Jan Kara

jbd2: Implement data=ordered mode handling via inodes

2008-07-11T23:27:31Z

This patch adds necessary framework into JBD2 to be able to track inodes with each transaction and write-out their dirty data during transaction commit time. This new ordered mode brings all sorts of advantages such as possibility to get rid of journal heads and buffer heads for data buffers in ordered mode, better ordering of writes on transaction commit, simplification of some JBD code, no more anonymous pages when truncate of data being committed happens. Also with this new ordered mode, delayed allocation on ordered mode is much simpler. Signed-off-by: Jan Kara

jbd2: fix race between jbd2_journal_try_to_free_buffers() and jbd2 commit transaction

2008-07-14T01:06:39Z

journal_try_to_free_buffers() could race with jbd commit transaction when the later is holding the buffer reference while waiting for the data buffer to flush to disk. If the caller of journal_try_to_free_buffers() request tries hard to release the buffers, it will treat the failure as error and return back to the caller. We have seen the directo IO failed due to this race. Some of the caller of releasepage() also expecting the buffer to be dropped when passed with GFP_KERNEL mask to the releasepage()->journal_try_to_free_buffers(). With this patch, if the caller is passing the GFP_KERNEL to indicating this call could wait, in case of try_to_free_buffers() failed, let's waiting for journal_commit_transaction() to finish commit the current committing transaction , then try to free those buffers again with journal locked. Signed-off-by: Mingming Cao Reviewed-by: Badari Pulavarty Signed-off-by: "Theodore Ts'o"

jdb2: replace remaining FUNCTION occurrences

2008-04-17T14:38:59Z

__FUNCTION__ is gcc-specific, use __func__ Signed-off-by: Harvey Harrison Cc: Signed-off-by: Andrew Morton Signed-off-by: "Theodore Ts'o"

jbd2: fix kernel-doc notation

2008-04-17T14:38:59Z

Fix kernel-doc notation in jbd2. Signed-off-by: Randy Dunlap Signed-off-by: Mingming Cao Signed-off-by: Andrew Morton Signed-off-by: "Theodore Ts'o"

jbd2: fix possible journal overflow issues

2008-04-17T14:38:59Z

There are several cases where the running transaction can get buffers added to its BJ_Metadata list which it never dirtied, which makes its t_nr_buffers counter end up larger than its t_outstanding_credits counter. This will cause issues when starting new transactions as while we are logging buffers we decrement t_outstanding_buffers, so when t_outstanding_buffers goes negative, we will report that we need less space in the journal than we actually need, so transactions will be started even though there may not be enough room for them. In the worst case scenario (which admittedly is almost impossible to reproduce) this will result in the journal running out of space. The fix is to only refile buffers from the committing transaction to the running transactions BJ_Modified list when b_modified is set on that journal, which is the only way to be sure if the running transaction has modified that buffer. This patch also fixes an accounting error in journal_forget, it is possible that we can call journal_forget on a buffer without having modified it, only gotten write access to it, so instead of freeing a credit, we only do so if the buffer was modified. The assert will help catch if this problem occurs. Without these two patches I could hit this assert within minutes of running postmark, with them this issue no longer arises. Cc: Cc: Jan Kara Signed-off-by: Josef Bacik Signed-off-by: Andrew Morton Signed-off-by: "Theodore Ts'o"

kernel.git/fs/jbd2/transaction.c, branch linux-2.6.28.y

jbd2: Avoid possible NULL dereference in jbd2_journal_begin_ordered_truncate()

ext4: Replace hackish ext4_mb_poll_new_transaction with commit callback

lockdep: rename map_[acquire|release]() => lock_map_[acquire|release]()

lockdep: map_acquire

jbd2: Remove data=ordered mode support using jbd buffer heads

jbd2: Implement data=ordered mode handling via inodes

jbd2: fix race between jbd2_journal_try_to_free_buffers() and jbd2 commit transaction

jdb2: replace remaining __FUNCTION__ occurrences

jbd2: fix kernel-doc notation

jbd2: fix possible journal overflow issues

jdb2: replace remaining FUNCTION occurrences