kernel.git/fs/f2fs/gc.c, branch linux-3.17.y

f2fs: reposition unlock_new_inode to prevent accessing invalid inode

2014-09-02T07:22:24Z

As the race condition on the inode cache, following scenario can appear: [Thread a] [Thread b] ->f2fs_mkdir ->f2fs_add_link ->__f2fs_add_link ->init_inode_metadata failed here ->gc_thread_func ->f2fs_gc ->do_garbage_collect ->gc_data_segment ->f2fs_iget ->iget_locked ->wait_on_inode ->unlock_new_inode ->move_data_page ->make_bad_inode ->iput When we fail in create/symlink/mkdir/mknod/tmpfile, the new allocated inode should be set as bad to avoid being accessed by other thread. But in above scenario, it allows f2fs to access the invalid inode before this inode was set as bad. This patch fix the potential problem, and this issue was found by code review. change log from v1: o Add condition judgment in gc_data_segment() suggested by Changman Lee. o use iget_failed to simplify code. Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim

f2fs: introduce f2fs_cp_error for readability

2014-08-21T16:21:00Z

This patch adds f2fs_cp_error for readability. Signed-off-by: Jaegeuk Kim

f2fs: fix typo

2014-08-19T17:01:33Z

Fix typo and some grammatical errors. The words "filesystem" and "readahead" are being used without the space treewide. Signed-off-by: Park Ju Hyung Signed-off-by: Jaegeuk Kim

f2fs: use for_each_set_bit to simplify the code

2014-08-04T20:20:53Z

This patch uses for_each_set_bit to simplify some codes in f2fs. Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim

f2fs: remove the unused ctor argument of f2fs_kmem_cache_create()

2014-03-10T09:45:14Z

Signed-off-by: Gu Zheng Signed-off-by: Jaegeuk Kim

f2fs: readahead contiguous SSA blocks for f2fs_gc

2014-02-27T11:40:36Z

If there are multi segments in one section, we will read those SSA blocks which have contiguous address one by one in f2fs_gc. It may lost performance, let's read ahead SSA blocks by merge multi read request. Signed-off-by: Chao Yu Signed-off-by: Jaegeuk Kim

f2fs: clean up redundant function call

2014-02-17T05:58:53Z

This patch integrates inode_[inc|dec]_dirty_dents with inc_page_count to remove redundant calls. Signed-off-by: Jaegeuk Kim

f2fs: fix f2fs_write_meta_page at no checkpoint status

2014-02-17T05:58:53Z

If f2fs entered errorneous checkpoint status, it should skip writing meta pages instead of redirtying the pages out. Otherwise, it cannot unmount the partition even though f2fs is under read-only status. Signed-off-by: Jaegeuk Kim

f2fs: remove the needless parameter of f2fs_wait_on_page_writeback

2014-01-14T08:45:54Z

"boo sync" parameter is never referenced in f2fs_wait_on_page_writeback. We should remove this parameter. Signed-off-by: Yuan Zhong Signed-off-by: Jaegeuk Kim

f2fs: add a sysfs entry to control max_victim_search

2014-01-08T04:45:08Z

Previously during SSR and GC, the maximum number of retrials to find a victim segment was hard-coded by MAX_VICTIM_SEARCH, 4096 by default. This number makes an effect on IO locality, when SSR mode is activated, which results in performance fluctuation on some low-end devices. If max_victim_search = 4, the victim will be searched like below. ("D" represents a dirty segment, and "*" indicates a selected victim segment.) D1 D2 D3 D4 D5 D6 D7 D8 D9 [ * ] [ * ] [ * ] [ ....] This patch adds a sysfs entry to control the number dynamically through: /sys/fs/f2fs/$dev/max_victim_search Signed-off-by: Jaegeuk Kim