kernel.git/fs/ext4/mmp.c, branch linux-4.7.y

ext4: remove trailing \n from ext4_warning/ext4_error calls

2016-04-27T05:11:21Z

Messages passed to ext4_warning() or ext4_error() don't need trailing newlines, because these function add the newlines themselves. Signed-off-by: Jakub Wilk

ext4: clean up error handling in the MMP support

2016-03-13T21:56:52Z

There is memory leak as both caller function kmmpd() and callee read_mmp_block() not releasing bh_check (i.e buffer_head). Given patch fixes this problem. [ Additional changes suggested by Andreas Dilger -- TYT ] Signed-off-by: Jadhav Vikram Signed-off-by: Theodore Ts'o

ext4: call out CRC and corruption errors with specific error codes

2015-10-17T20:16:04Z

Instead of overloading EIO for CRC errors and corrupt structures, return the same error codes that XFS returns for the same issues. Signed-off-by: Darrick J. Wong Signed-off-by: Theodore Ts'o

ext4: silence a format string false positive

2015-08-15T15:38:13Z

Static checkers complain that the format string should be "%s". It does not make a difference for the current code. Signed-off-by: Dan Carpenter Signed-off-by: Theodore Ts'o

ext4: simplify some code in read_mmp_block()

2015-08-15T15:30:31Z

My static check complains because we have: if (!*bh) return -ENOMEM; if (*bh) { The second check is unnecessary. I've simplified this code by moving the "if (!*bh)" checks around. Also Andreas Dilger says we should probably print a warning if sb_getblk() fails. [ Restructured the code so that we print a warning message as well if the mmp block doesn't check out, and to print the error code to disambiguate between the error cases. - TYT ] Reviewed-by: Andreas Dilger Signed-off-by: Dan Carpenter Signed-off-by: Theodore Ts'o

ext4: Replace open coded mdata csum feature to helper function

2014-10-13T07:36:16Z

Besides the fact that this replacement improves code readability it also protects from errors caused direct EXT4_S(sb)->s_es manipulation which may result attempt to use uninitialized csum machinery. #Testcase_BEGIN IMG=/dev/ram0 MNT=/mnt mkfs.ext4 $IMG mount $IMG $MNT #Enable feature directly on disk, on mounted fs tune2fs -O metadata_csum $IMG # Provoke metadata update, likey result in OOPS touch $MNT/test umount $MNT #Testcase_END # Replacement script @@ expression E; @@ - EXT4_HAS_RO_COMPAT_FEATURE(E, EXT4_FEATURE_RO_COMPAT_METADATA_CSUM) + ext4_has_metadata_csum(E) https://bugzilla.kernel.org/show_bug.cgi?id=82201 Signed-off-by: Dmitry Monakhov Signed-off-by: Theodore Ts'o Cc: stable@vger.kernel.org

ext4: make local functions static

2014-05-12T14:50:23Z

I have been running make namespacecheck to look for unneeded globals, and found these in ext4. Signed-off-by: Stephen Hemminger Signed-off-by: "Theodore Ts'o"

ext4: use prandom_u32() instead of get_random_bytes()

2013-11-08T05:14:53Z

Many of the uses of get_random_bytes() do not actually need cryptographically secure random numbers. Replace those uses with a call to prandom_u32(), which is faster and which doesn't consume entropy from the /dev/random driver. Signed-off-by: "Theodore Ts'o"

ext4: mark all metadata I/O with REQ_META

2013-04-20T19:46:17Z

As Dave Chinner pointed out at the 2013 LSF/MM workshop, it's important that metadata I/O requests are marked as such to avoid priority inversions caused by I/O bandwidth throttling. Signed-off-by: "Theodore Ts'o"

ext4: fix big-endian bug in metadata checksum calculations

2013-04-10T03:56:48Z

Signed-off-by: Dmitry Monakhov Signed-off-by: "Theodore Ts'o" Cc: stable@vger.kernel.org