kernel.git/fs/ext4/dir.c, branch linux-3.18.y

ext4: avoid divide by zero fault when deleting corrupted inline directories

2018-10-13T07:09:23Z

commit 4d982e25d0bdc83d8c64e66fdeca0b89240b3b85 upstream. A specially crafted file system can trick empty_inline_dir() into reading past the last valid entry in a inline directory, and then run into the end of xattr marker. This will trigger a divide by zero fault. Fix this by using the size of the inline directory instead of dir->i_size. Also clean up error reporting in __ext4_check_dir_entry so that the message is clearer and more understandable --- and avoids the division by zero trap if the size passed in is zero. (I'm not sure why we coded it that way in the first place; printing offset % size is actually more confusing and less useful.) https://bugzilla.kernel.org/show_bug.cgi?id=200933 Signed-off-by: Theodore Ts'o Reported-by: Wen Xu Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman

ext4: convert ext4_bread() to use the ERR_PTR convention

2014-08-30T00:52:15Z

Signed-off-by: Theodore Ts'o

ext4: check inline directory before converting

2014-07-28T17:06:26Z

Before converting an inline directory to a regular directory, check the directory entries to make sure they're not obviously broken. This helps us to avoid a BUG_ON if one of the dirents is trashed. Signed-off-by: Darrick J. Wong Signed-off-by: Theodore Ts'o Reviewed-by: Andreas Dilger

ext4: remove unused local variable "stored" from ext4_readdir(...)

2014-05-27T16:48:55Z

Remove local variable "stored" from ext4_readdir(...). This variable gets initialized but is never used inside the function. Signed-off-by: Giedrius Rekasius Signed-off-by: Theodore Ts'o

fs/ext4: use rbtree postorder iteration helper instead of opencoding

2014-01-24T00:37:03Z

Use rbtree_postorder_for_each_entry_safe() to destroy the rbtree instead of opencoding an alternate postorder iteration that modifies the tree Signed-off-by: Cody P Schafer Reviewed-by: Jan Kara Cc: Michel Lespinasse Cc: Theodore Ts'o Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds

ext4: Fix misspellings using 'codespell' tool

2013-08-28T18:40:12Z

Signed-off-by: Anatol Pomozov Signed-off-by: "Theodore Ts'o"

[readdir] convert ext4

2013-06-29T08:56:40Z

and trim the living hell out bogosities in inline dir case Signed-off-by: Al Viro

ext4: fix readdir error in the case of inline_data+dir_index

2013-04-19T21:53:09Z

Zach reported a problem that if inline data is enabled, we don't tell the difference between the offset of '.' and '..'. And a getdents will fail if the user only want to get '.' and what's worse, if there is a conversion happens when the user calls getdents many times, he/she may get the same entry twice. In theory, a dir block would also fail if it is converted to a hashed-index based dir since f_pos will become a hash value, not the real one, but it doesn't happen. And a deep investigation shows that we uses a hash based solution even for a normal dir if the dir_index feature is enabled. So this patch just adds a new htree_inlinedir_to_tree for inline dir, and if we find that the hash index is supported, we will do like what we do for a dir block. Reported-by: Zach Brown Signed-off-by: Tao Ma Signed-off-by: "Theodore Ts'o"

Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4

2013-03-03T03:33:21Z

Pull ext4 bug fixes from Ted Ts'o: "Various bug fixes for ext4. The most important is a fix for the new extent cache's slab shrinker which can cause significant, user-visible pauses when the system is under memory pressure." * tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4: ext4: enable quotas before orphan cleanup ext4: don't allow quota mount options when quota feature enabled ext4: fix a warning from sparse check for ext4_dir_llseek ext4: convert number of blocks to clusters properly ext4: fix possible memory leak in ext4_remount() jbd2: fix ERR_PTR dereference in jbd2__journal_start ext4: use percpu counter for extent cache count ext4: optimize ext4_es_shrink()

ext4: fix a warning from sparse check for ext4_dir_llseek

2013-03-02T22:24:05Z

ext4_dir_llseek is only used as a callback function, and no one calls it directly. So make it as a static function in order to remove a warning message from sparse check. Signed-off-by: Zheng Liu Signed-off-by: "Theodore Ts'o"