kernel.git/fs/ext4/acl.c, branch linux-2.6.37.y

ext4: update ctime when changing the file's permission by setfacl

2010-06-15T16:19:59Z

ext4 didn't update the ctime of the file when its permission was changed. Steps to reproduce: # touch aaa # stat -c %Z aaa 1275289822 # setfacl -m 'u::x,g::x,o::x' aaa # stat -c %Z aaa 1275289822 <- unchanged But, according to the spec of the ctime, ext4 must update it. Port of ext3 patch by Miao Xie . CC: linux-ext4@vger.kernel.org Signed-off-by: Jan Kara Signed-off-by: "Theodore Ts'o"

ext4: constify xattr_handler

2010-05-21T22:31:19Z

Signed-off-by: Stephen Hemminger Signed-off-by: Al Viro

sanitize xattr handler prototypes

2009-12-16T17:16:49Z

Add a flags argument to struct xattr_handler and pass it to all xattr handler methods. This allows using the same methods for multiple handlers, e.g. for the ACL methods which perform exactly the same action for the access and default ACLs, just using a different underlying attribute. With a little more groundwork it'll also allow sharing the methods for the regular user/trusted/secure handlers in extN, ocfs2 and jffs2 like it's already done for xfs in this patch. Also change the inode argument to the handlers to a dentry to allow using the handlers mechnism for filesystems that require it later, e.g. cifs. [with GFS2 bits updated by Steven Whitehouse ] Signed-off-by: Christoph Hellwig Reviewed-by: James Morris Acked-by: Joel Becker Signed-off-by: Al Viro

ext[234]: move over to 'check_acl' permission model

2009-09-08T18:09:04Z

Don't implement per-filesystem 'extX_permission()' functions that have to be called for every path component operation, and instead just expose the actual ACL checking so that the VFS layer can now do it for us. Reviewed-by: James Morris Acked-by: Serge Hallyn Signed-off-by: Linus Torvalds

helpers for acl caching + switch to those

2009-06-24T12:17:07Z

helpers: get_cached_acl(inode, type), set_cached_acl(inode, type, acl), forget_cached_acl(inode, type). ubifs/xattr.c needed includes reordered, the rest is a plain switchover. Signed-off-by: Al Viro

switch ext4 to inode->i_acl

2009-06-24T12:17:04Z

Signed-off-by: Al Viro

ext4: avoid unnecessary spinlock in critical POSIX ACL path

2009-06-17T04:36:35Z

If a filesystem supports POSIX ACL's, the VFS layer expects the filesystem to do POSIX ACL checks on any files not owned by the caller, and it does this for every single pathname component that it looks up. That obviously can be pretty expensive if the filesystem isn't careful about it, especially with locking. That's doubly sad, since the common case tends to be that there are no ACL's associated with the files in question. ext4 already caches the ACL data so that it doesn't have to look it up over and over again, but it does so by taking the inode->i_lock spinlock on every lookup. Which is a noticeable overhead even if it's a private lock, especially on CPU's where the serialization is expensive (eg Intel Netburst aka 'P4'). For the special case of not actually having any ACL's, all that locking is unnecessary. Even if somebody else were to be changing the ACL's on another CPU, we simply don't care - if we've seen a NULL ACL, we might as well use it. So just load the ACL speculatively without any locking, and if it was NULL, just use it. If it's non-NULL (either because we had a cached entry, or because the cache hasn't been filled in at all), it means that we'll need to get the lock and re-load it properly. (This commit was ported from a patch originally authored by Linus for ext3.) Signed-off-by: "Theodore Ts'o" Signed-off-by: Al Viro

New helper - current_umask()

2009-04-01T03:00:26Z

current->fs->umask is what most of fs_struct users are doing. Put that into a helper function. Signed-off-by: Al Viro

ext4: Cleanup whitespace and other miscellaneous style issues

2008-07-26T20:15:44Z

Signed-off-by: "Theodore Ts'o"

[PATCH] sanitize ->permission() prototype

2008-07-27T00:53:14Z

* kill nameidata * argument; map the 3 bits in ->flags anybody cares about to new MAY_... ones and pass with the mask. * kill redundant gfs2_iop_permission() * sanitize ecryptfs_permission() * fix remaining places where ->permission() instances might barf on new MAY_... found in mask. The obvious next target in that direction is permission(9) folded fix for nfs_permission() breakage from Miklos Szeredi Signed-off-by: Al Viro