kernel.git/fs/dlm/lock.c, branch linux-2.6.28.y

dlm: fix uninitialized variable for search_rsb_list callers

2008-07-14T18:56:59Z

gcc 4.3.0 correctly emits the following warning. search_rsb_list does not *r_ret if no dlm_rsb is found and _search_rsb may pass the uninitialized value upstream on the error path when both calls to search_rsb_list return non-zero error. The fix sets *r_ret to NULL on search_rsb_list's not-found path. Signed-off-by: Benny Halevy Signed-off-by: David Teigland

dlm: fix basts for granted CW waiting PR/CW

2008-07-14T18:56:59Z

The fix in commit 3650925893469ccb03dbcc6a440c5d363350f591 was addressing the case of a granted PR lock with waiting PR and CW locks. It's a special case that requires forcing a CW bast. However, that forced CW bast was incorrectly applying to a second condition where the granted lock was CW. So, the holder of a CW lock could receive an extraneous CW bast instead of a PR bast. This fix narrows the original special case to what was intended. Signed-off-by: David Teigland

dlm: save master info after failed no-queue request

2008-04-21T16:18:01Z

When a NOQUEUE request fails, the rsb res_master field is unnecessarily reset to -1, instead of leaving the valid master setting in place. We want to save the looked-up master values while the rsb is on the "toss list" so that another lookup can be avoided if the rsb is soon reused. The fix is to simply leave res_master value alone. Signed-off-by: David Teigland

dlm: make dlm_print_rsb() static

2008-04-21T16:18:01Z

dlm_print_rsb() can now become static. Signed-off-by: Adrian Bunk Signed-off-by: David Teigland

dlm: eliminate astparam type casting

2008-02-07T05:27:04Z

Put lkb_astparam in a union with a dlm_user_args pointer to eliminate a lot of type casting. Signed-off-by: David Teigland

dlm: proper types for asts and basts

2008-02-06T06:35:45Z

Use proper types for ast and bast functions, and use consistent type for ast param. Signed-off-by: David Teigland

dlm: fix overflows when copying from ->m_extra to lvb

2008-02-04T07:29:13Z

Signed-off-by: Al Viro Signed-off-by: David Teigland

dlm: make find_rsb() fail gracefully when namelen is too large

2008-02-04T07:26:31Z

We *can* get there from receive_request() and dlm_recover_master_copy() with namelen too large if incoming request is invalid; BUG() from DLM_ASSERT() in allocate_rsb() is a bit excessive reaction to that and in case of dlm_recover_master_copy() we would actually oops before that while calculating hash of up to 64Kb worth of data - with data actually being 64 _bytes_ in kmalloc()'ed struct. Signed-off-by: Al Viro Signed-off-by: David Teigland

dlm: receive_rcom_lock_args() overflow check

2008-02-04T07:25:58Z

Signed-off-by: Al Viro Signed-off-by: David Teigland

dlm: verify that places expecting rcom_lock have packet long enough

2008-02-04T07:25:09Z

Signed-off-by: Al Viro Signed-off-by: David Teigland