kernel.git/fs/bcachefs/io_write.c, branch linux-6.7.y

bcachefs: fix buffer overflow in nocow write path

2024-01-01T16:46:52Z

BCH_REPLICAS_MAX isn't the actual maximum number of pointers in an extent, it's the maximum number of dirty pointers. We don't have a real restriction on the number of cached pointers, and we don't want a fixed size array here anyways - so switch to DARRAY_PREALLOCATED(). Signed-off-by: Kent Overstreet Reported-and-tested-by: Daniel J Blueman

closures: CLOSURE_CALLBACK() to fix type punning

2023-11-24T05:29:58Z

Control flow integrity is now checking that type signatures match on indirect function calls. That breaks closures, which embed a work_struct in a closure in such a way that a closure_fn may also be used as a workqueue fn by the underlying closure code. So we have to change closure fns to take a work_struct as their argument - but that results in a loss of clarity, as closure fns have different semantics from normal workqueue functions (they run owning a ref on the closure, which must be released with continue_at() or closure_return()). Thus, this patc introduces CLOSURE_CALLBACK() and closure_type() macros as suggested by Kees, to smooth things over a bit. Suggested-by: Kees Cook Cc: Coly Li Signed-off-by: Kent Overstreet

bcachefs: Fix no_data_io mode checksum check

2023-11-15T04:44:44Z

In no_data_io mode, we expect data checksums to be wrong - don't want to spew the log with them. Signed-off-by: Kent Overstreet

bcachefs: x-macro-ify inode flags enum

2023-11-05T18:12:18Z

This lets us use bch2_prt_bitflags to print them out. Signed-off-by: Kent Overstreet

bcachefs: Add a comment for BTREE_INSERT_NOJOURNAL usage

2023-11-05T02:19:13Z

BTREE_INSERT_NOJOURNAL is primarily used for a performance optimization related to inode updates and fsync - document it. Signed-off-by: Kent Overstreet

bcachefs: Add IO error counts to bch_member

2023-11-02T01:11:08Z

We now track IO errors per device since filesystem creation. IO error counts can be viewed in sysfs, or with the 'bcachefs show-super' command. Signed-off-by: Kent Overstreet

bcachefs: rebalance_work

2023-11-02T01:11:05Z

This adds a new btree, rebalance_work, to eliminate scanning required for finding extents that need work done on them in the background - i.e. for the background_target and background_compression options. rebalance_work is a bitset btree, where a KEY_TYPE_set corresponds to an extent in the extents or reflink btree at the same pos. A new extent field is added, bch_extent_rebalance, which indicates that this extent has work that needs to be done in the background - and which options to use. This allows per-inode options to be propagated to indirect extents - at least in some circumstances. In this patch, changing IO options on a file will not propagate the new options to indirect extents pointed to by that file. Updating (setting/clearing) the rebalance_work btree is done by the extent trigger, which looks at the bch_extent_rebalance field. Scanning is still requrired after changing IO path options - either just for a given inode, or for the whole filesystem. We indicate that scanning is required by adding a KEY_TYPE_cookie key to the rebalance_work btree: the cookie counter is so that we can detect that scanning is still required when an option has been flipped mid-way through an existing scan. Future possible work: - Propagate options to indirect extents when being changed - Add other IO path options - nr_replicas, ec, to rebalance_work so they can be applied in the background when they change - Add a counter, for bcachefs fs usage output, showing the pending amount of rebalance work: we'll probably want to do this after the disk space accounting rewrite (moving it to a new btree) Signed-off-by: Kent Overstreet

bcachefs: Check for too-large encoded extents

2023-10-31T16:18:37Z

We don't yet repair (split) them, just check. Signed-off-by: Kent Overstreet

bcachefs: Ensure we don't exceed encoded_extent_max

2023-10-31T16:18:37Z

The write path may (rarely) see an encoded (checksummed) extent that exceeds encoded_extent_max - this can happen when we're moving an existing extent that was not checksummed, but was given a checksum by bch2_write_rechecksum(). Signed-off-by: Kent Overstreet

bcachefs: nocow locking: Fix lock leak

2023-10-22T21:10:15Z

Signed-off-by: Kent Overstreet