kernel.git/fs/bcachefs/inode.c, branch linux-6.7.y

bcachefs: Fix deleted inode check for dirs

2023-12-08T05:39:56Z

We could delete directories transactionally on rmdir()/unlink(), but we don't; instead, like with regular files we wait for the VFS to call evict(). That means that our check for directories in the deleted inodes btree is wrong - the check should be for non-empty directories. Signed-off-by: Kent Overstreet

bcachefs: Fix missing transaction commit

2023-11-15T04:44:43Z

In may_delete_deleted_inode(), there's a corner case when a snapshot was taken while we had an unlinked inode: we don't want to delete the inode in the internal (shared) snapshot node, since it might have been reattached in a descendent snapshot. Instead we propagate the key to any snapshot leaves it doesn't exist in, so that it can be deleted there if necessary, and then clear the unlinked flag in the internal node. But we forgot to commit after clearing the unlinked flag, causing us to go into an infinite loop. Signed-off-by: Kent Overstreet

bcachefs: Fix iterator leak in may_delete_deleted_inode()

2023-11-15T04:44:43Z

may_delete_deleted_inode() was returning without exiting a btree iterator, eventually causing propagate_key_to_snaphot_leaves() to go into an infinite loop hitting btree_trans_too_many_iters(). Signed-off-by: Kent Overstreet

bcachefs: x-macro-ify inode flags enum

2023-11-05T18:12:18Z

This lets us use bch2_prt_bitflags to print them out. Signed-off-by: Kent Overstreet

bcachefs: Fix bch2_delete_dead_inodes()

2023-11-05T02:19:13Z

- the fsck_err() check for the filesystem being clean was incorrect, causing us to always fail to delete unlinked inodes - if a snapshot had been taken, the unlinked inode needs to be propagated to snapshot leaves so the unlink can happen there - fixed. Signed-off-by: Kent Overstreet

bcachefs: Enumerate fsck errors

2023-11-02T01:11:08Z

This patch adds a superblock error counter for every distinct fsck error; this means that when analyzing filesystems out in the wild we'll be able to see what sorts of inconsistencies are being found and repair, and hence what bugs to look for. Errors validating bkeys are not yet considered distinct fsck errors, but this patch adds a new helper, bkey_fsck_err(), in order to add distinct error types for them as well. Signed-off-by: Kent Overstreet

bcachefs: bch2_inum_opts_get()

2023-10-31T16:18:38Z

New helper for new rebalance code Signed-off-by: Kent Overstreet

bcachefs: Guard against unknown compression options

2023-10-31T16:18:37Z

Since compression options now include compression level, proper validation is a bit more involved. This adds bch2_compression_opt_valid(), and plumbs it around appropriately. Signed-off-by: Kent Overstreet

bcachefs: Fix bch2_inode_delete_keys()

2023-10-22T21:10:15Z

bch2_inode_delete_keys() was using BTREE_ITER_NOT_EXTENTS, on the assumption that it would never need to split extents. But that caused a race with extents being split by other threads - specifically, the data move path. Extents iterators have the iterator position pointing to the start of the extent, which avoids the race. Signed-off-by: Kent Overstreet

bcachefs: bch_err_msg(), bch_err_fn() now filters out transaction restart errors

2023-10-22T21:10:15Z

These errors aren't actual errors, and should never be printed - do this in the common helpers. Signed-off-by: Kent Overstreet