kernel.git/fs/bcachefs/bkey.c, branch linux-6.7.y

bcachefs: Fix W=12 build errors

2023-10-22T21:10:13Z

Signed-off-by: Kent Overstreet

bcachefs: Array bounds fixes

2023-10-22T21:10:12Z

It's no longer legal to use a zero size array as a flexible array member - this causes UBSAN to complain. This patch switches our zero size arrays to normal flexible array members when possible, and inserts casts in other places (e.g. where we use the zero size array as a marker partway through an array). Signed-off-by: Kent Overstreet

bcachefs: Fix bkey format calculation

2023-10-22T21:10:11Z

For extents, we increase the number of bits of the size field to allow extents to get bigger due to merging - but this code didn't check for overflow. Signed-off-by: Kent Overstreet

bcachefs: BCH_COMPAT_bformat_overflow_done no longer required

2023-10-22T21:10:09Z

Awhile back, we changed bkey_format generation to ensure that the packed representation could never represent fields larger than the unpacked representation. This was to ensure that bkey_packed_successor() always gave a sensible result, but in the current code bkey_packed_successor() is only used in a debug assertion - not for anything important. This kills the requirement that we've gotten rid of those weird bkey formats, and instead changes the assertion to check if we're dealing with an old weird bkey format. Signed-off-by: Kent Overstreet

bcachefs: kill EBUG_ON() redefinition in bkey.c

2023-10-22T21:10:09Z

our debug mode assertions in bkey.c haven't been getting run, whoops Signed-off-by: Kent Overstreet

bcachefs: Fix shift by 64 in set_inc_field()

2023-10-22T21:10:09Z

UBSAN was complaining about a shift by 64 in set_inc_field(). This only happened when the value being shifted was 0, so in theory should be harmless - a shift by 64 (or register width) should logically give a result of 0, but CPUs will in practice leave the input unchanged when the number of bits to shift by wraps - and since our input here is 0, the output is still what we want. But, it's still undefined behaviour and we need our UBSAN output to be clean, so it needs to be fixed. Signed-off-by: Kent Overstreet

bcachefs: bkey_format helper improvements

2023-10-22T21:10:09Z

- add a to_text() method for bkey_format - convert bch2_bkey_format_validate() to modern error message style, where we pass a printbuf for the error string instead of returning a static string Signed-off-by: Kent Overstreet

bcachefs: Use memcpy_u64s_small() for copying keys

2023-10-22T21:10:01Z

Small performance optimization; an open coded loop is better than rep ; movsq for small copies. Signed-off-by: Kent Overstreet

bcachefs: Add some unlikely() annotations

2023-10-22T21:09:48Z

Add a few easy unlikely() optimizations. These are mainly worthwhile because the compiler will (usually) put the branch-not-taken path at the end of the function, meaning better icache utilization. Signed-off-by: Kent Overstreet

bcachefs: extents no longer require special handling for packing

2023-10-22T21:09:47Z

Extent overwrite used to be handled differently, underneath the journaling layer and within the core btree code. This imposed restrictions on bkey packing/packed formats, which no longer apply. This patch deletes those restrictions. Signed-off-by: Kent Overstreet