kernel.git/fs/bcachefs/acl.c, branch linux-6.7.y

bcachefs: make RO snapshots actually RO

2024-01-01T16:47:07Z

Add checks to all the VFS paths for "are we in a RO snapshot?". Note - we don't check this when setting inode options via our xattr interface, since those generally only affect data placement, not contents of data. Signed-off-by: Kent Overstreet Reported-by: "Carl E. Thompson"

bcachefs: acl: Add missing check in bch2_acl_chmod()

2023-10-22T21:10:14Z

The "ret = bkey_err(k);" assignment was accidentally left out so the call to bch2_btree_iter_peek_slot() is not checked for errors. Fixes: 53306e096d91 ("bcachefs: Always check for transaction restarts") Signed-off-by: Dan Carpenter Signed-off-by: Kent Overstreet

bcachefs: acl: Uninitialized variable in bch2_acl_chmod()

2023-10-22T21:10:14Z

The clean up code at the end of the function uses "acl" so it needs to be initialized to NULL. Fixes: 53306e096d91 ("bcachefs: Always check for transaction restarts") Signed-off-by: Dan Carpenter Signed-off-by: Kent Overstreet

bcachefs: Heap allocate btree_trans

2023-10-22T21:10:13Z

We're using more stack than we'd like in a number of functions, and btree_trans is the biggest object that we stack allocate. But we have to do a heap allocatation to initialize it anyways, so there's no real downside to heap allocating the entire thing. Signed-off-by: Kent Overstreet

bcachefs: bch2_acl_to_text()

2023-10-22T21:10:12Z

We can now print out acls from bch2_xattr_to_text(), when the xattr contains an acl. Signed-off-by: Kent Overstreet

bcachefs: Assorted sparse fixes

2023-10-22T21:10:06Z

- endianness fixes - mark some things static - fix a few __percpu annotations - fix silent enum conversions Signed-off-by: Kent Overstreet

bcachefs: Convert acl.c to allocate_dropping_locks()

2023-10-22T21:10:03Z

More work to avoid allocating memory with btree locks held. Signed-off-by: Kent Overstreet

bcachefs: Convert -ENOENT to private error codes

2023-10-22T21:10:03Z

As with previous conversions, replace -ENOENT uses with more informative private error codes. Signed-off-by: Kent Overstreet

bcachefs: Assorted checkpatch fixes

2023-10-22T21:09:44Z

checkpatch.pl gives lots of warnings that we don't want - suggested ignore list: ASSIGN_IN_IF UNSPECIFIED_INT - bcachefs coding style prefers single token type names NEW_TYPEDEFS - typedefs are occasionally good FUNCTION_ARGUMENTS - we prefer to look at functions in .c files (hopefully with docbook documentation), not .h file prototypes MULTISTATEMENT_MACRO_USE_DO_WHILE - we have _many_ x-macros and other macros where we can't do this Signed-off-by: Kent Overstreet

bcachefs: EINTR -> BCH_ERR_transaction_restart

2023-10-22T21:09:37Z

Now that we have error codes, with subtypes, we can switch to our own error code for transaction restarts - and even better, a distinct error code for each transaction restart reason: clearer code and better debugging. Signed-off-by: Kent Overstreet