kernel.git/drivers/video/fbdev/ssd1307fb.c, branch linux-4.18.y

video: ssd1307fb: Improve a size determination in ssd1307fb_probe()

2018-03-28T14:34:28Z

Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Cc: Arnd Bergmann Cc: Bastian Stender Cc: Jyri Sarha Cc: Tomi Valkeinen Signed-off-by: Bartlomiej Zolnierkiewicz

fbdev/ssd1307fb: fix optional VBAT support

2017-04-07T15:28:23Z

SSD1306 needs VBAT when it is wired in charge pump configuration only. Other controllers of the SSD1307 family do not need it at all. This was introduced by commit ba14301e0356 ("fbdev/ssd1307fb: add support to enable VBAT"). Without VBAT configuration the driver now fails with: failed to get VBAT regulator: -19 This is caused by misinterpretation of devm_regulator_get_optional which "returns a struct regulator corresponding to the regulator producer or IS_ERR() condition". Handle -ENODEV without bailing out and making VBAT support really optional. Signed-off-by: Bastian Stender Cc: Tomi Valkeinen Cc: Jyri Sarha Cc: Roger Quadros [b.zolnierkie: minor fixups] Signed-off-by: Bartlomiej Zolnierkiewicz

fbdev: ssd1307fb: include linux/gpio/consumer.h

2017-02-20T12:51:07Z

Changing this driver to the gpiod API requires the use of the new-style header, depending on the configuration: drivers/video/fbdev/ssd1307fb.c: In function 'ssd1307fb_probe': drivers/video/fbdev/ssd1307fb.c:569:15: error: implicit declaration of function 'devm_gpiod_get_optional';did you mean 'devm_regulator_get_optional'? [-Werror=implicit-function-declaration] drivers/video/fbdev/ssd1307fb.c:570:11: error: 'GPIOD_OUT_LOW' undeclared (first use in this function) Fixes: 72db33355c14 ("fbdev: ssd1307fb: Start to use gpiod API for reset gpio") Cc: Tomi Valkeinen Cc: Jyri Sarha Cc: LABBE Corentin Signed-off-by: Arnd Bergmann Signed-off-by: Bartlomiej Zolnierkiewicz

fbdev/ssd1307fb: clear screen in probe

2017-02-08T15:44:00Z

SSD1306 does not clear the panel's framebuffer automatically, even if a HW reset happens, so we need to do that at probe time before enabling the panel. Cc: Rob Herring Cc: Maxime Ripard Cc: Benoît Cousson Signed-off-by: Tomi Valkeinen Signed-off-by: Jyri Sarha Signed-off-by: Bartlomiej Zolnierkiewicz

fbdev/ssd1307fb: add support to enable VBAT

2017-02-08T15:43:59Z

SSD1306 needs VBAT when it is wired in charge pump configuration. This patch adds support to the driver to enable VBAT regulator at init time. Cc: Rob Herring Cc: Maxime Ripard Cc: Benoît Cousson Signed-off-by: Tomi Valkeinen Reviewed-by: Roger Quadros Signed-off-by: Jyri Sarha Signed-off-by: Bartlomiej Zolnierkiewicz

fbdev: ssd1307fb: Make reset gpio devicetree property optional

2017-02-08T15:43:59Z

Make reset gpio devicetree property optional. Depending on the board designing there may not be a dedicated gpio for resetting the display. Without a proper reset there may be some junk in the display memory at probe time, so in such a case the display memory is cleared before turning it on. The devicetree binding document is also updated. Cc: Rob Herring Cc: Tomi Valkeinen Cc: Maxime Ripard Cc: Benoît Cousson Signed-off-by: Jyri Sarha Signed-off-by: Bartlomiej Zolnierkiewicz

fbdev: ssd1307fb: Start to use gpiod API for reset gpio

2017-02-08T15:43:59Z

Start to use gpiod API for reset gpio. Cc: Rob Herring Cc: Tomi Valkeinen Cc: Maxime Ripard Cc: Benoît Cousson Signed-off-by: Jyri Sarha Signed-off-by: Bartlomiej Zolnierkiewicz

fbdev: ssd1307fb: fix a possible NULL dereference

2016-09-27T08:41:30Z

of_match_device could return NULL, and so cause a NULL pointer dereference later. For fixing this problem, we use of_device_get_match_data(), this will simplify the code a little by using a standard function for getting the match data. Signed-off-by: LABBE Corentin Signed-off-by: Tomi Valkeinen

fbdev: ssd1307fb: constify the device_info pointer

2016-09-27T08:41:30Z

of_match_device return const data, so instead of casting its return value this patch constify the device_info pointer. Signed-off-by: LABBE Corentin Signed-off-by: Tomi Valkeinen

video: fbdev: constify fb_fix_screeninfo and fb_var_screeninfo structures

2016-09-27T08:16:35Z

These structures are only used to copy into other structures, so declare them as const. The semantic patch that makes this change in the fb_fix_screeninfo case is as follows (http://coccinelle.lip6.fr/). The fb_var_screeninfo case is analogous. // @r disable optional_qualifier@ identifier i; position p; @@ static struct fb_fix_screeninfo i@p = { ... }; @ok@ identifier r.i; expression e; position p; @@ e = i@p @bad@ position p != {r.p,ok.p}; identifier r.i; struct fb_fix_screeninfo e; @@ e@i@p @depends on !bad disable optional_qualifier@ identifier r.i; @@ static +const struct fb_fix_screeninfo i = { ... }; // Signed-off-by: Julia Lawall Signed-off-by: Tomi Valkeinen