kernel.git/drivers/video/fbdev/au1200fb.c, branch linux-4.18.y

video: fbdev: fix spelling mistake: "frambuffer" -> "framebuffer"

2018-05-15T10:41:11Z

Trivial fix to spelling mistake in error messages. Signed-off-by: Colin Ian King Cc: Markus Elfring Cc: Christophe JAILLET Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: au1200fb: Style clean up

2017-11-09T17:09:30Z

Style clean-up. Signed-off-by: Christophe JAILLET Cc: Tejun Heo Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: au1200fb: Propagate an error code

2017-11-09T17:09:29Z

We should propagate the error code returned by 'fb_alloc_cmap()' instead of returning -EFAULT. Signed-off-by: Christophe JAILLET Cc: Tejun Heo Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: au1200fb: Remove some dead code

2017-11-09T17:09:29Z

There is no need to shut gcc up. It should not complain. Axe 'fbdev', it is never used in this function. Signed-off-by: Christophe JAILLET Cc: Tejun Heo Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: au1200fb: Fix error handling path

2017-11-09T17:09:29Z

Rewrite the exit path based on 'au1200fb_drv_remove()'. We can safely iterate for all already handled planes. Even if not completely initialized, the functions that are called will silently accept the 'fb_info' structure that is passed. As soon as we find a NULL in the '_au1200fb_infos' array, we know that we have released all what we needed to release. So we can 'break'. Signed-off-by: Christophe JAILLET Cc: Tejun Heo Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: au1200fb: Fix incorrect IRQ freeing

2017-11-09T17:09:29Z

'au1200fb_drv_probe()' can not fail after a successful call to 'request_irq()'. So there is no point to call 'free_irq()' in the error handling path. Moreover, the hard coded AU1200_LCD_INT looks boggus since commit 1630d85a8312 ("au1200fb: fix hardcoded IRQ"). So, remove it. Signed-off-by: Christophe JAILLET Cc: Tejun Heo [b.zolnierkie: patch summary and description fixups] Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: au1200fb: Release some resources if a memory allocation fails

2017-11-09T17:09:28Z

We should go through the error handling code instead of returning -ENOMEM directly. Signed-off-by: Christophe JAILLET Cc: Tejun Heo Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: au1200fb: Return an error code if a memory allocation fails

2017-11-09T17:09:28Z

'ret' is known to be 0 at this point. In case of memory allocation error in 'framebuffer_alloc()', return -ENOMEM instead. Signed-off-by: Christophe JAILLET Cc: Tejun Heo Signed-off-by: Bartlomiej Zolnierkiewicz

video: fbdev: au1200fb: Fix a potential double free

2017-11-09T17:09:28Z

If 'fb_alloc_cmap()' fails, 'fbi->pseudo_palette' is freed and an error code is returned by 'au1200fb_init_fbinfo()'. The only caller, 'au1200fb_drv_probe()' goes to an error handling path where resources allocated in 'fb_alloc_cmap()' are freed. This leads to a double free of 'fbi->pseudo_palette'. Fix it by letting the caller free all resources in case of failure in 'au1200fb_init_fbinfo()'. Signed-off-by: Christophe JAILLET Cc: Tejun Heo Signed-off-by: Bartlomiej Zolnierkiewicz

dma-mapping: replace dmam_alloc_noncoherent with dmam_alloc_attrs

2017-06-28T13:55:00Z

dmam_alloc_noncoherent is a trivial wrapper around dmam_alloc_attrs, that hardcodes one particular flag. Make the devres code more flexible by allowing the callers to pass arbitrary flags. Signed-off-by: Christoph Hellwig Acked-by: Tejun Heo