kernel.git/drivers/usb/musb, branch linux-4.18.y

usb: musb: dsps: do not disable CPPI41 irq in driver teardown

2018-10-03T23:59:19Z

commit 783f3b4e9ec50491c21746e7e05ec6c39c21f563 upstream. TI AM335x CPPI 4.1 module uses a single register bit for CPPI interrupts in both musb controllers. So disabling the CPPI irq in one musb driver breaks the other musb module. Since musb is already disabled before tearing down dma controller in musb_remove(), it is safe to not disable CPPI irq in musb_dma_controller_destroy(). Fixes: 255348289f71 ("usb: musb: dsps: Manage CPPI 4.1 DMA interrupt in DSPS") Cc: stable@vger.kernel.org Signed-off-by: Bin Liu Signed-off-by: Greg Kroah-Hartman

USB: musb: clean up debugfs file and directory creation

2018-05-31T10:54:21Z

When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Because of this, lots of init functions do not need to have return values, so this cleans up a lot of unused error handling code that never could have triggered in the past. Cc: Bin Liu Signed-off-by: Greg Kroah-Hartman

usb: musb: remove an unused variable

2018-05-31T10:44:39Z

After the only users of this variable got removed, we now get a warning about 'otg' being unused: drivers/usb/musb/da8xx.c: In function 'da8xx_musb_interrupt': drivers/usb/musb/da8xx.c:226:19: error: unused variable 'otg' [-Werror=unused-variable] Fixes: d2852f2d3e6d ("usb: musb: remove references to default_a of struct usb_otg") Signed-off-by: Arnd Bergmann Signed-off-by: Greg Kroah-Hartman

usb: musb: gadget: fix to_musb_ep() to not return NULL

2018-05-22T10:03:25Z

UDC core ensures the usb_ep parameter passed in is not NULL, so checking if (ep != NULL) is pointless. Convert to_musb_ep() to a simple macro to not directly return NULL to avoid warnings from code static analysis tools. Signed-off-by: Bin Liu Signed-off-by: Greg Kroah-Hartman

usb: musb: gadget: fix to_musb_request() to not return NULL

2018-05-22T10:03:25Z

The gadget function drivers should ensure the usb_request parameter passed in is not NULL. UDC core doesn't check if it is NULL, so MUSB driver shouldn't have to check it either. Convert to_musb_request() to a simple macro to not directly return NULL to avoid warnings from code static analysis tools. Signed-off-by: Bin Liu Signed-off-by: Greg Kroah-Hartman

USB: musb: dsps: propagate device-tree node

2018-05-22T10:03:25Z

To be able to use DSPS-based controllers with device-tree descriptions of the USB topology, we need to associate the glue device's device-tree node with the child controller device. Note that this can also be used to eventually let USB core manage generic phys. Also note that the other glue drivers will require similar changes to be able to describe their buses in DT. Signed-off-by: Johan Hovold Signed-off-by: Bin Liu Signed-off-by: Greg Kroah-Hartman

usb: musb: disable otg protocol support

2018-05-22T10:03:25Z

As decided in the discussion [1] we are deleting the otg protocol support from the musb drivers. First this patch disables the flags for enabling the otg protocols. We will later gradually delete the otg protocol code from the musb drivers. [1] https://www.spinics.net/lists/linux-usb/msg167003.html Signed-off-by: Bin Liu Signed-off-by: Greg Kroah-Hartman

usb: musb: remove references to default_a of struct usb_otg

2018-05-22T10:03:25Z

musb drivers do not use the otg fsm framework, so referencing to otg->default_a doesn't have any effect, so remove the references. But tusb6010 glue driver uses it locally to control the vbus power, so keep the references in tusb6010 only. Signed-off-by: Bin Liu Signed-off-by: Greg Kroah-Hartman

usb: musb: break the huge isr musb_stage0_irq() into small functions

2018-05-22T10:03:25Z

musb_stage0_irq() is 400+ lines long. Break its interrupt events handling into each individual functions to make it easy to read. Signed-off-by: Bin Liu Signed-off-by: Greg Kroah-Hartman

usb: musb: remove unused members in struct musb_hdrc_config

2018-05-22T10:03:25Z

The following members in struct musb_hdrc_config are not used, so remove them. soft_con utm_16 big_endian mult_bulk_tx mult_bulk_rx high_iso_tx high_iso_rx dma dma_channels dyn_fifo_size vendor_ctrl vendor_stat vendor_req dma_req_chan musb_hdrc_eps_bits Signed-off-by: Bin Liu Signed-off-by: Greg Kroah-Hartman