kernel.git/drivers/thunderbolt/nhi.c, branch linux-4.4.y

thunderbolt: Use 32-bit writes when writing ring producer/consumer

2019-11-06T11:09:17Z

[ Upstream commit 943795219d3cb9f8ce6ce51cad3ffe1f61e95c6b ] The register access should be using 32-bit reads/writes according to the datasheet. With the previous generation hardware 16-bit writes have been working but starting with ICL this is not the case anymore so fix producer/consumer register update to use correct width register address. Signed-off-by: Mika Westerberg Reviewed-by: Yehezkel Bernat Tested-by: Mario Limonciello Signed-off-by: Sasha Levin

thunderbolt: Resume control channel after hibernation image is created

2018-04-24T07:32:07Z

commit f2a659f7d8d5da803836583aa16df06bdf324252 upstream. The driver misses implementation of PM hook that undoes what ->freeze_noirq() does after the hibernation image is created. This means the control channel is not resumed properly and the Thunderbolt bus becomes useless in later stages of hibernation (when the image is stored or if the operation fails). Fix this by pointing ->thaw_noirq to driver nhi_resume_noirq(). This makes sure the control channel is resumed properly. Fixes: 23dd5bb49d98 ("thunderbolt: Add suspend/hibernate support") Signed-off-by: Mika Westerberg Reviewed-by: Andy Shevchenko Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman

thunderbolt: Allow loading of module on recent Apple MacBooks with thunderbolt 2 controller

2015-09-20T22:20:11Z

The pci device ids listed in the thunderbolt driver are to restrictive, which prevents the driver from being loaded on recent Apple MacBooks using a thunderbolt 2 controller. In particular this prevented any hot-plugging functionality for thunderbolt based ethernet dongles (i.e. Apples thunderbolt gigabit ethernet broadcom tg3 based dongle Model A1433 EMC 2590). Changing the subvendor and subdevice to PCI_ANY_ID the thunderbolt driver loads and binds to the pci device 07:00.0 System peripheral: Intel Corporation Device 156c which is the thunderbolt 2 controller on the MacBookPro12,1. Successfully tested on MacBookPro12,1. With the patch the thunderbolt module gets now loaded on boot. And it provides hot-plugging support both for a cold-plugged and a warm-plugged ethernet dongle. Signed-off-by: Andreas Noever Acked-by: Knuth Posern Signed-off-by: Greg Kroah-Hartman

thunderbolt: Use kcalloc

2014-07-13T20:16:50Z

The advantage of kcalloc is, that will prevent integer overflows which could result from the multiplication of number of elements and size and it is also a bit nicer to read. Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall Acked-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman

thunderbolt: Correct the size argument to devm_kzalloc

2014-07-08T01:56:20Z

nhi->rx_rings does not have type as struct tb_ring *, as it is a double pointer so the elements of the array should have pointer type, not structure type. The Coccinelle semantic patch that makes this change is as follows: // @disable sizeof_type_expr@ type T; T **x; @@ x = <+...sizeof( - T + *x )...+> // Signed-off-by: Himangi Saraogi Acked-by: Julia Lawall Cc: Andreas Noever Signed-off-by: Greg Kroah-Hartman

thunderbolt: Staticize nhi_ids

2014-06-20T16:44:42Z

'nhi_ids' is local to this file. Signed-off-by: Sachin Kamat Acked-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman

thunderbolt: Use NULL instead of 0 in nhi.c

2014-06-20T16:44:42Z

'descriptors' is a pointer. Use NULL isntead of 0. Signed-off-by: Sachin Kamat Acked-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman

thunderbolt: Add suspend/hibernate support

2014-06-19T21:13:00Z

We use _noirq since we have to restore the pci tunnels before the pci core wakes the tunneled devices. Signed-off-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman

thunderbolt: Setup control channel

2014-06-19T21:07:07Z

Add struct tb which will contain our view of the thunderbolt bus. For now it just contains a pointer to the control channel and a workqueue for hotplug events. Add thunderbolt_alloc_and_start() and thunderbolt_shutdown_and_free() which are responsible for setup and teardown of struct tb. Signed-off-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman

thunderbolt: Add initial cactus ridge NHI support

2014-06-19T21:04:52Z

Thunderbolt hotplug is supposed to be handled by the firmware. But Apple decided to implement thunderbolt at the operating system level. The firmare only initializes thunderbolt devices that are present at boot time. This driver enables hotplug of thunderbolt of non-chained thunderbolt devices on Apple systems with a cactus ridge controller. This first patch adds the Kconfig file as well the parts of the driver which talk directly to the hardware (that is pci device setup, interrupt handling and RX/TX ring management). Signed-off-by: Andreas Noever Signed-off-by: Greg Kroah-Hartman