kernel.git/drivers/target/sbp, branch linux-3.8.y

sbp-target: fix error path in sbp_make_tpg()

2012-12-13T05:17:25Z

If the TPG memory is allocated successfully, but we fail further along in the function, a dangling pointer to freed memory is left in the TPort structure. This is mostly harmless, but does prevent re-trying the operation without first removing the TPort altogether. Reported-by: Chen Gang Signed-off-by: Chris Boot Cc: Andy Grover Cc: Nicholas A. Bellinger Cc: stable@vger.kernel.org Signed-off-by: Nicholas Bellinger

sbp-target: use simple assignment in tgt_agent_rw_agent_state()

2012-12-13T05:16:47Z

There is no need to memcpy() a 32-bit integer. The data pointer is guaranteed to be quadlet aligned by the FireWire stack so we can replace the memcpy() with an assignment. Thanks to Stefan Richter. Signed-off-by: Chris Boot Cc: Stefan Richter Cc: Andy Grover Cc: Clemens Ladisch Cc: Nicholas A. Bellinger Signed-off-by: Nicholas Bellinger

sbp-target: remove depends on CONFIG_EXPERIMENTAL

2012-11-08T04:12:09Z

The CONFIG_EXPERIMENTAL config item has not carried much meaning for a while now and is almost always enabled by default. As agreed during the Linux kernel summit, remove it from any "depends on" lines in Kconfigs. CC: Chris Boot CC: "Nicholas A. Bellinger" Signed-off-by: Kees Cook Signed-off-by: Nicholas Bellinger

sbp-target: fix return value check in sbp_register_configfs()

2012-09-22T23:29:52Z

In case of error, the function target_fabric_configfs_init() returns ERR_PTR() not NULL pointer. The NULL test in the return value check should be replaced with IS_ERR(). dpatch engine is used to auto generated this patch. (https://github.com/weiyj/dpatch) Signed-off-by: Wei Yongjun Signed-off-by: Nicholas Bellinger

target: use list_move_tail instead of list_del/list_add_tail

2012-09-18T00:13:36Z

Using list_move_tail() instead of list_del() + list_add_tail(). spatch with a semantic match is used to found this problem. (http://coccinelle.lip6.fr/) Signed-off-by: Wei Yongjun Signed-off-by: Nicholas Bellinger

target: Simplify fabric sense data length handling

2012-09-18T00:12:58Z

Every fabric driver has to supply a se_tfo->set_fabric_sense_len() method, just so iSCSI can return an offset of 2. However, every fabric driver is already allocating a sense buffer and passing it into the target core, either via transport_init_se_cmd() or target_submit_cmd(). So instead of having iSCSI pass the start of its sense buffer into the core and then later tell the core to skip the first 2 bytes, it seems easier for iSCSI just to do the offset of 2 when it passes the sense buffer into the core. Then we can drop the se_tfo->set_fabric_sense_len() everywhere, and just add a couple of lines of code to iSCSI to set the sense data length to the beginning of the buffer right before it sends it over the network. (nab: Remove .set_fabric_sense_len usage from tcm_qla2xxx_npiv_ops + change transport_get_sense_buffer to follow v3.6-rc6 code w/o ->set_fabric_sense_len usage) Signed-off-by: Roland Dreier Signed-off-by: Nicholas Bellinger

target: Remove unused target_core_fabric_ops.get_fabric_sense_len method

2012-09-17T23:15:47Z

There are no callers of se_tfo->get_fabric_sense_len(), so we should stop having every fabric driver implement it. Signed-off-by: Roland Dreier Signed-off-by: Nicholas Bellinger

target/sbp: Remove strict param from sbp_parse_wwn

2012-09-17T23:15:47Z

It's always set, and controls whether uppercase A-F are allowed hex values. I don't see a reason not to accept these. Signed-off-by: Andy Grover Cc: Chris Boot Signed-off-by: Nicholas Bellinger

target: Allow for target_submit_cmd() returning errors

2012-07-18T00:05:05Z

We want it to be possible for target_submit_cmd() to return errors up to its fabric module callers. For now just update the prototype to return an int, and update all callers to handle non-zero return values as an error. This is immediately useful for tcm_qla2xxx to fix a long-standing active I/O session shutdown race, but tcm_fc, usb-gadget, and sbp-target the fabric maintainers need to check + ACK that handling a target_submit_cmd() failure due to session shutdown does not introduce regressions (nab: Respin against for-next after initial NACK + update docbook comment + fix double se_cmd init in exception path for usb-gadget) Cc: Chad Dupuis Cc: Arun Easi Cc: Chris Boot Cc: Stefan Richter Cc: Mark Rustad Cc: Sebastian Andrzej Siewior Cc: Felipe Balbi Cc: Andy Grover Signed-off-by: Roland Dreier Signed-off-by: Nicholas Bellinger

sbp-target: Consolidate duplicated error path code in sbp_handle_command()

2012-07-17T00:35:26Z

Cc: Chris Boot Cc: Stefan Richter Signed-off-by: Roland Dreier