kernel.git/drivers/scsi/scsi_error.c, branch linux-2.6.16.y

[SCSI] scsi: scsi command retries off by one fix

2006-02-28T03:38:39Z

Fix up an off by one error in calculating retries for scsi commands. This bug was discovered when an SG_IO request was sent to scsi core with retries = 0, causing the overall timeout check to go off in scsi_softirq_done. Signed-off-by: Brian King Signed-off-by: James Bottomley

[SCSI] Prevent scsi_execute_async from guessing cdb length

2006-01-26T20:13:50Z

When the scsi_execute_async interface was added it ended up reducing the flexibility of userspace to send arbitrary scsi commands through sg using SG_IO. The SG_IO interface allows userspace to specify the CDB length. This is now ignored in scsi_execute_async and it is guessed using the COMMAND_SIZE macro, which is not always correct, particularly for vendor specific commands. This patch adds a cmd_len parameter to the scsi_execute_async interface to allow the caller to specify the length of the CDB. Signed-off-by: Brian King Signed-off-by: James Bottomley

Merge by hand (conflicts in scsi_lib.c)

2005-12-15T23:35:24Z

This merge is pretty extensive. The conflict is over the new req->retries parameter, so I had to change the prototype to scsi_setup_blk_pc_cmnd() and the usage in sd, sr and st. Signed-off-by: James Bottomley

[SCSI] Convert SCSI mid-layer to scsi_execute_async

2005-12-15T03:03:35Z

Add scsi helpers to create really-large-requests and convert scsi-ml to scsi_execute_async(). Per Jens's previous comments, I placed this function in scsi_lib.c. I made it follow all the queue's limits - I think I did at least :), so I removed the warning on the function header. I think the scsi_execute_* functions should eventually take a request_queue and be placed some place where the dm-multipath hw_handler can use them if that failover code is going to stay in the kernel. That conversion patch will be sent in another mail though. Signed-off-by: Mike Christie Signed-off-by: James Bottomley

[SCSI] fix OOPS due to clearing eh_action prior to aborting eh command

2005-12-08T14:13:29Z

The eh_action semaphore in scsi_eh_send_command is cleared after a command timeout. The command is subsequently aborted and the abort will try to call scsi_done() on it. Unfortunately, the scsi_eh_done() routine unconditinally completes the semaphore (which is now null). Fix this race by makiong the scsi_eh_done() routine check that the semaphore is non null before completing it (mirroring the ordinary command done/timeout logic). Signed-off-by: James Bottomley

[SCSI] use a completion in scsi_send_eh_cmnd

2005-11-06T18:49:36Z

scsi_send_eh_cmnd currently uses a semaphore and an overload of eh_timer to either get a completion for a command for a timeout. Switch to using a completion and wait_for_completion_timeout to simply the code and not having to deal with the races ourselves. Signed-off-by: Christoph Hellwig Signed-off-by: James Bottomley

[SCSI] remove Scsi_Host.eh_active

2005-11-06T18:44:44Z

now that the abuse in qla2xxx is gone this field can be remove. Signed-off-by: Christoph Hellwig Signed-off-by: James Bottomley

[SCSI] tidy up scsi_error_handler

2005-11-06T18:43:26Z

adjust comments, remove a useless cast and remove a write-only variable. Signed-off-by: Christoph Hellwig Signed-off-by: James Bottomley

[SCSI] use scmd_id(), scmd_channel() throughout code

2005-10-29T02:10:16Z

Wrap a highly common idiom. Makes the code easier to read, helps pave the way for sdev->{id,channel} removal, and adds a token that can easily by grepped-for in the future. There are a couple sdev_id() and scmd_printk() updates thrown in as well. Rejections fixed up and Signed-off-by: James Bottomley

[SCSI] use {sdev,scmd,starget,shost}_printk in generic code

2005-10-29T01:52:11Z

rejections fixed and Signed-off-by: James Bottomley