kernel.git/drivers/scsi/libfc/fc_exch.c, branch linux-4.16.y

scsi: libfc: Don't have fc_exch_find log errors on a new exchange

2016-11-08T22:29:58Z

With the error message I added in "libfc: sanity check cpu number extracted from xid" I didn't account for the fact that fc_exch_find is called with FC_XID_UNKNOWN at the start of a new exchange if we are the responder. It doesn't come up with the initiator much, but that's basically every exchange for a target. By checking the xid for FC_XID_UNKNOWN first, we not only prevent the erroneous error message, but skip the unnecessary lookup attempt as well. [mkp: applied by hand due to conflict with Hannes' libfc patch series] Signed-off-by: Chris Leech Reviewed-by: Ewan D. Milne Reviewed-by: Hannes Reinecke Signed-off-by: Martin K. Petersen

scsi: libfc: Replace ->seq_release callback with function call

2016-11-08T22:29:56Z

The ->seq_release callback only ever had one implementation, so call the function directly and drop the callback. Signed-off-by: Hannes Reinecke Acked-by: Johannes Thumshirn Signed-off-by: Martin K. Petersen

scsi: libfc: Replace ->seq_assign callback with function call

2016-11-08T22:29:56Z

The ->seq_assign callback only ever had one implementation, so call the function directly and drop the callback. Signed-off-by: Hannes Reinecke Acked-by: Johannes Thumshirn Signed-off-by: Martin K. Petersen

scsi: libfc: Replace ->seq_set_resp callback with direct function call

2016-11-08T22:29:56Z

The ->seq_set_resp callback only ever had one implementation, so call it directly and drop the callback. Signed-off-by: Hannes Reinecke Acked-by: Johannes Thumshirn Signed-off-by: Martin K. Petersen

scsi: libfc: Replace ->seq_start_next callback with function call

2016-11-08T22:29:56Z

The ->seq_start_next callback only ever had one implementation, so call the function directly and drop the callback. Signed-off-by: Hannes Reinecke Acked-by: Johannes Thumshirn Signed-off-by: Martin K. Petersen

scsi: libfc: Replace ->exch_done callback with function call

2016-11-08T22:29:56Z

The ->exch_done callback only ever had one implementation, so we can as well call it directly and drop the callback. Signed-off-by: Hannes Reinecke Acked-by: Johannes Thumshirn Signed-off-by: Martin K. Petersen

scsi: libfc: Replace ->seq_exch_abort callback with function call

2016-11-08T22:29:56Z

The ->seq_exch_abort callback only ever had one implementation, so we can as well call it directly and drop the callback. Signed-off-by: Hannes Reinecke Acked-by: Johannes Thumshirn Signed-off-by: Martin K. Petersen

scsi: libfc: Replace ->seq_send callback with function call

2016-11-08T22:29:56Z

The ->seq_send callback only ever had one implementation, so we can as well call it directly and drop the callback. Signed-off-by: Hannes Reinecke Acked-by: Johannes Thumshirn Signed-off-by: Martin K. Petersen

scsi: libfc: Replace ->exch_seq_send callback with function call

2016-11-08T22:29:55Z

The ->exch_seq_send callback only ever had one implementation, so we can call the function directly and drop the callback. Signed-off-by: Hannes Reinecke Acked-by: Johannes Thumshirn Signed-off-by: Martin K. Petersen

scsi: libfc: Replace ->lport_recv with function call

2016-11-08T22:29:54Z

The ->lport_recv callback only ever had one implementation, so call the function directly and remove the callback. Signed-off-by: Hannes Reinecke Acked-by: Johannes Thumshirn Signed-off-by: Martin K. Petersen