kernel.git/drivers/scsi/iscsi_boot_sysfs.c, branch linux-4.4.y

scsi: iscsi: Fix reference count leak in iscsi_boot_create_kobj

2020-06-30T00:07:53Z

[ Upstream commit 0267ffce562c8bbf9b57ebe0e38445ad04972890 ] kobject_init_and_add() takes reference even when it fails. If this function returns an error, kobject_put() must be called to properly clean up the memory associated with the object. Link: https://lore.kernel.org/r/20200528201353.14849-1-wu000273@umn.edu Reviewed-by: Lee Duncan Signed-off-by: Qiushi Wu Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin

[SCSI] iscsi_boot_sysfs: Fix a memory leak in iscsi_boot_destroy_kset()

2014-03-15T17:19:19Z

Load and unload iscsi_ibft module will cause kernel memory leak, fix it in scsi/iscsi_boot_sysfs.c iscsi_boot_destroy_kset(). Signed-off-by: Ethan Zhao Signed-off-by: Mike Christie Signed-off-by: James Bottomley

switch ->is_visible() to returning umode_t

2012-01-04T03:54:55Z

Signed-off-by: Al Viro

[SCSI] iscsi_ibft, be2iscsi, iscsi_boot: fix boot kobj data lifetime management

2011-06-29T21:43:06Z

be2iscsi passes the boot functions its phba object which is allocated in the shost, but iscsi_ibft passes in a object allocated for each item to display. The problem is that iscsi_boot_sysfs was managing the lifetime of the object passed in and doing a kfree on release. This causes a double free for be2iscsi which frees the shost in its pci_remove. This patch fixes the problem by adding a release callback which the drivers can call kfree or a put() type of function (needed for be2iscsi which will do a get/put on the shost). Signed-off-by: Mike Christie Signed-off-by: James Bottomley

[SCSI] iscsi_boot_sysfs: have this module check for null on destruction

2011-06-29T21:43:03Z

This moves the check for NULL boot_sets to the iscsi_boot_sysfs module instead of having the drivers do it. Signed-off-by: Mike Christie Signed-off-by: James Bottomley

[SCSI] iscsi boot: mv iscsi_boot_sysfs to drivers/scsi

2010-08-06T15:45:07Z

iscsi_boot_sysfs does not depend on firmware. Any iscsi driver can use it. This patch moves iscsi_boot_sysfs to the scsi dir, so that it can be used on any arch with any driver. Signed-off-by: Mike Christie Acked-by: Konrad Rzeszutek Wilk Signed-off-by: James Bottomley