kernel.git/drivers/platform/x86/surface3_power.c, branch linux-5.10.y

surface: surface3_power: Fix battery readings on batteries without a serial number

2022-03-02T10:42:51Z

commit 21d90aaee8d5c2a097ef41f1430d97661233ecc6 upstream. The battery on the 2nd hand Surface 3 which I recently bought appears to not have a serial number programmed in. This results in any I2C reads from the registers containing the serial number failing with an I2C NACK. This was causing mshw0011_bix() to fail causing the battery readings to not work at all. Ignore EREMOTEIO (I2C NACK) errors when retrieving the serial number and continue with an empty serial number to fix this. Fixes: b1f81b496b0d ("platform/x86: surface3_power: MSHW0011 rev-eng implementation") BugLink: https://github.com/linux-surface/linux-surface/issues/608 Reviewed-by: Benjamin Tissoires Reviewed-by: Maximilian Luz Signed-off-by: Hans de Goede Link: https://lore.kernel.org/r/20220224101848.7219-1-hdegoede@redhat.com Signed-off-by: Greg Kroah-Hartman

platform/x86: surface3_power: Fix a NULL vs IS_ERR() check in probe

2020-04-17T13:47:26Z

The i2c_acpi_new_device() function never returns NULL, it returns error pointers. Fixes: b1f81b496b0d ("platform/x86: surface3_power: MSHW0011 rev-eng implementation") Signed-off-by: Dan Carpenter Signed-off-by: Andy Shevchenko

platform/x86: surface3_power: Fix always true condition in mshw0011_space_handler()

2020-03-30T10:26:50Z

smatch warnings: .../surface3_power.c:417 mshw0011_space_handler() warn: always true condition '(ret >= 0) => +(0-u32max >= 0)' Refactor error handling returned by mshw0011_adp_psr() to avoid always true condition. Reported-by: kbuild test robot Signed-off-by: Andy Shevchenko

platform/x86: surface3_power: Add missed headers

2020-03-28T20:37:30Z

We obviously are users of bits.h and types.h. Add them to the list. Signed-off-by: Andy Shevchenko

platform/x86: surface3_power: Reformat GUID assignment

2020-03-28T20:37:29Z

For better readability reformat GUID assignment. While here, add the comment how this GUID looks in a string representation. Signed-off-by: Andy Shevchenko

platform/x86: surface3_power: Drop useless macro ACPI_PTR()

2020-03-28T20:37:29Z

Driver depends to ACPI, this marco always is evaluated to the parameter, thus useless. Drop it for good. Signed-off-by: Andy Shevchenko

platform/x86: surface3_power: Prefix POLL_INTERVAL with SURFACE_3

2020-03-28T20:37:29Z

For better namespace maintenance prefix POLL_INTERVAL macro with SURFACE_3. Signed-off-by: Andy Shevchenko

platform/x86: surface3_power: Simplify mshw0011_adp_psr() to one liner

2020-03-28T20:37:29Z

Refactor mshw0011_adp_psr() to be one liner. Signed-off-by: Andy Shevchenko

platform/x86: surface3_power: Use dev_err() instead of pr_err()

2020-03-28T20:37:29Z

We have device and we may use it to print messages. Signed-off-by: Andy Shevchenko

platform/x86: surface3_power: Drop unused structure definition

2020-03-28T20:37:29Z

As reported by kbuild bot the struct mshw0011_lookup in never used. Drop its definition for good. Reported-by: kbuild test robot Signed-off-by: Andy Shevchenko