kernel.git/drivers/net/wwan, branch linux-5.16.y

net: wwan: Fix MRU mismatch issue which may lead to data connection lost

2022-01-27T11:03:02Z

commit f542cdfa3083a309e3caafbbdf41490c4935492a upstream. In pci_generic.c there is a 'mru_default' in struct mhi_pci_dev_info. This value shall be used for whole mhi if it's given a value for a specific product. But in function mhi_net_rx_refill_work(), it's still using hard code value MHI_DEFAULT_MRU. 'mru_default' shall have higher priority than MHI_DEFAULT_MRU. And after checking, this change could help fix a data connection lost issue. Fixes: 5c2c85315948 ("bus: mhi: pci-generic: configurable network interface MRU") Signed-off-by: Shujun Wang Signed-off-by: Slark Xiao Reviewed-by: Loic Poulain Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman

net: wwan: iosm: fixes unable to send AT command during mbim tx

2021-12-09T16:10:35Z

ev_cdev_write_pending flag is preventing a TX message post for AT port while MBIM transfer is ongoing. Removed the unnecessary check around control port TX transfer. Signed-off-by: M Chetan Kumar Reviewed-by: Sergey Ryazanov Signed-off-by: Jakub Kicinski

net: wwan: iosm: fixes net interface nonfunctional after fw flash

2021-12-09T16:10:35Z

Devlink initialization flow was overwriting the IP traffic channel configuration. This was causing wwan0 network interface to be unusable after fw flash. When device boots to fully functional mode restore the IP channel configuration. Signed-off-by: M Chetan Kumar Reviewed-by: Sergey Ryazanov Signed-off-by: Jakub Kicinski

net: wwan: iosm: fixes unnecessary doorbell send

2021-12-09T16:10:35Z

In TX packet accumulation flow transport layer is giving a doorbell to device even though there is no pending control TX transfer that needs immediate attention. Introduced a new hpda_ctrl_pending variable to keep track of pending control TX transfer. If there is a pending control TX transfer which needs an immediate attention only then give a doorbell to device. Signed-off-by: M Chetan Kumar Reviewed-by: Sergey Ryazanov Signed-off-by: Jakub Kicinski

net: wwan: iosm: fix compilation warning

2021-11-11T11:45:44Z

curr_phase is unused. Removed the dead code. Fixes: 8d9be0634181 ("net: wwan: iosm: transport layer support for fw flashing/cd") Reported-by: kernel test robot Signed-off-by: M Chetan Kumar Reviewed-by: Loic Poulain Signed-off-by: David S. Miller

net: wwan: iosm: correct devlink extra params

2021-10-02T15:05:20Z

1. Removed driver specific extra params like download_region, address & region_count. The required information is passed as part of flash API. 2. IOSM Devlink documentation updated to reflect the same. Signed-off-by: M Chetan Kumar Signed-off-by: David S. Miller

net: wwan: iosm: Move devlink_register to be last devlink command

2021-09-27T15:31:59Z

This change prevents from users to access device before devlink is fully configured. Indirectly this change fixes the commit mentioned below where devlink_unregister() was prematurely removed. Fixes: db4278c55fa5 ("devlink: Make devlink_register to be void") Signed-off-by: Leon Romanovsky Signed-off-by: David S. Miller

net: iosm: Use hrtimer_forward_now()

2021-09-24T13:09:40Z

hrtimer_forward_now() is providing the same functionality. Preparation for making hrtimer_forward() timer core code only. Signed-off-by: Thomas Gleixner Cc: Loic Poulain Cc: netdev@vger.kernel.org Cc: Sergey Ryazanov Cc: Jakub Kicinski Cc: M Chetan Kumar Cc: Johannes Berg Cc: "David S. Miller" Cc: Intel Corporation Signed-off-by: David S. Miller

net: wwan: iosm: fw flashing and cd improvements

2021-09-22T13:23:33Z

1> Function comments moved to .c file. 2> Use literals in return to improve readability. 3> Do error handling check instead of success check. 4> Redundant ret assignment removed. Signed-off-by: M Chetan Kumar Signed-off-by: David S. Miller

devlink: Make devlink_register to be void

2021-09-22T13:15:12Z

devlink_register() can't fail and always returns success, but all drivers are obligated to check returned status anyway. This adds a lot of boilerplate code to handle impossible flow. Make devlink_register() void and simplify the drivers that use that API call. Signed-off-by: Leon Romanovsky Acked-by: Simon Horman Acked-by: Vladimir Oltean # dsa Reviewed-by: Jiri Pirko Signed-off-by: David S. Miller