kernel.git/drivers/net/wan/farsync.c, branch linux-5.14.yHosts the 0x221E linux distro kernel.
https://git.0xinfinity.dev/distro/kernel.git/atom?h=linux-5.14.y2021-06-08T19:04:05Znet: farsync: replace comparison to NULL with "fst_card_array[i]"2021-06-08T19:04:05ZPeng Li2021-06-08T08:12:42Zurn:sha1:f23a3da78a31d2ec7029c9637bf57ec892ada40c
According to the chackpatch.pl, comparison to NULL could
be written "fst_card_array[i]".
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: farsync: remove redundant return2021-06-08T19:04:05ZPeng Li2021-06-08T08:12:41Zurn:sha1:f01f906ffefc71e5d370e7542884820d1318358b
Void function return statements are not generally useful.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: farsync: fix the alignment issue2021-06-08T19:04:05ZPeng Li2021-06-08T08:12:40Zurn:sha1:d2a1054b8b02afdaae8119fdd7bf1171fd2fce2b
Alignment should match open parenthesis.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: farsync: remove redundant parentheses2021-06-08T19:04:05ZPeng Li2021-06-08T08:12:39Zurn:sha1:ae1be3fad5695fcb5ad1053b4847f89431f7b922
Unnecessary parentheses around 'port->hwif == X21'.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: farsync: remove redundant spaces2021-06-08T19:04:05ZPeng Li2021-06-08T08:12:38Zurn:sha1:b64b5aee73580ec223a95d28b359117b52436ff9
According to the chackpatch.pl,
space prohibited between function name and open parenthesis '(',
no space is necessary after a cast.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: farsync: remove redundant braces {}2021-06-08T19:04:05ZPeng Li2021-06-08T08:12:37Zurn:sha1:fa8d10b54760c4869e7d3d6b57e4e5a694f0d112
This patch removes redundant braces {}, to fix the
checkpatch.pl warning:
"braces {} are not necessary for single statement blocks".
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: farsync: add some required spaces2021-06-08T19:04:05ZPeng Li2021-06-08T08:12:36Zurn:sha1:37947a9be3d1a5d551e34f56653c5ccf86814cc3
Add spaces required around that '=' and '*'.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: farsync: fix the code style issue about macros2021-06-08T19:04:05ZPeng Li2021-06-08T08:12:35Zurn:sha1:7619ab161892edb6826504f8549ee78e568cf793
Macros with complex values should be enclosed in parentheses.
space required after that ',' .
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: farsync: code indent use tabs where possible2021-06-08T19:04:05ZPeng Li2021-06-08T08:12:34Zurn:sha1:3a950181f6f58b13ee4475cafe45170ed738c2af
Code indent should use tabs where possible.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net: farsync: remove trailing whitespaces2021-06-08T19:04:05ZPeng Li2021-06-08T08:12:33Zurn:sha1:d70711da30f0bec1286aab6f01f4a0ac6da1db79
This patch removes trailing whitespaces.
Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>