kernel.git/drivers/net/can/mscan, branch linux-3.16.y

can: mscan: mscan_rx_poll(): fix rx path lockup when returning from polling to irq mode

2020-04-28T18:03:13Z

commit 2d77bd61a2927be8f4e00d9478fe6996c47e8d45 upstream. Under load, the RX side of the mscan driver can get stuck while TX still works. Restarting the interface locks up the system. This behaviour could be reproduced reliably on a MPC5121e based system. The patch fixes the return value of the NAPI polling function (should be the number of processed packets, not constant 1) and the condition under which IRQs are enabled again after polling is finished. With this patch, no more lockups were observed over a test period of ten days. Fixes: afa17a500a36 ("net/can: add driver for mscan family & mpc52xx_mscan") Signed-off-by: Florian Faber Signed-off-by: Marc Kleine-Budde Signed-off-by: Ben Hutchings

can: mpc5xxx_can: check of_iomap return before use

2018-11-20T18:05:47Z

commit b5c1a23b17e563b656cc9bb76ce5323b997d90e8 upstream. of_iomap() can return NULL so that return needs to be checked and NULL treated as failure. While at it also take care of the missing of_node_put() in the error path. Signed-off-by: Nicholas Mc Guire Fixes: commit afa17a500a36 ("net/can: add driver for mscan family & mpc52xx_mscan") Signed-off-by: Marc Kleine-Budde Signed-off-by: Ben Hutchings

can: constify of_device_id array

2018-11-20T18:05:46Z

commit 486e957033623656298a07c39a8bf2fd81db285b upstream. of_device_id is always used as const. (See driver.of_match_table and open firmware functions) Signed-off-by: Fabian Frederick Signed-off-by: David S. Miller Signed-off-by: Ben Hutchings

can: mscan: Fix Kconfig dependencies

2014-05-19T07:38:21Z

The only driver based on MSCAN at the moment is for PPC machines, so it makes no sense to present the menu on M68K. The menu will always be empty there. Signed-off-by: Jean Delvare Cc: Wolfgang Grandegger Cc: Marc Kleine-Budde Signed-off-by: Marc Kleine-Budde

can: Unify MTU settings for CAN interfaces

2014-03-17T08:20:16Z

CAN interfaces only support MTU values of 16 (CAN 2.0) and 72 (CAN FD). Setting the MTU to other values is pointless but it does not really hurt. With the introduction of the CAN FD support in drivers/net/can a new function to switch the MTU for CAN FD has been introduced. This patch makes use of this can_change_mtu() function to check for correct MTU settings also in legacy CAN (2.0) devices. Signed-off-by: Oliver Hartkopp Signed-off-by: Marc Kleine-Budde

Merge remote-tracking branch 'agust/next' into next

2014-01-29T05:53:55Z

<< Switch mpc512x to the common clock framework and adapt mpc512x drivers to use the new clock driver. Old PPC_CLOCK code is removed entirely since there are no users any more. >>

net: can: mscan: remove non-CCF code for MPC512x

2014-01-12T17:53:05Z

transition to the common clock framework has completed and the PPC_CLOCK is no longer available for the MPC512x platform, remove the now obsolete code path of the mpc5xxx mscan driver which accessed clock control module registers directly Cc: Wolfgang Grandegger Cc: Marc Kleine-Budde Cc: linux-can@vger.kernel.org Signed-off-by: Gerhard Sittig Signed-off-by: Anatolij Gustschin

net: can: mscan: adjust to common clock support for mpc512x

2014-01-12T17:53:05Z

implement a .get_clock() callback for the MPC512x platform which uses the common clock infrastructure (eliminating direct access to the clock control registers from within the CAN network driver), and provide the corresponding .put_clock() callback to release resources after use acquire both the clock items for register access ("ipg") as well as for wire communication ("can") keep the previous implementation of MPC512x support in place during migration, this results in a readable diff of the change this change is neutral to the MPC5200 platform Cc: Wolfgang Grandegger Cc: Marc Kleine-Budde Cc: linux-can@vger.kernel.org Signed-off-by: Gerhard Sittig Signed-off-by: Anatolij Gustschin

can: Fix FSF address in file headers

2013-12-17T10:47:21Z

Several files refer to an old address for the Free Software Foundation in the file header comment. Resolve by replacing the address with the URL so that we do not have to keep updating the header comments anytime the address changes. CC: Wolfgang Grandegger CC: Marc Kleine-Budde Signed-off-by: Jeff Kirsher Signed-off-by: Marc Kleine-Budde

can: Remove extern from function prototypes

2013-09-24T14:09:18Z

There are a mix of function prototypes with and without extern in the kernel sources. Standardize on not using extern for function prototypes. Function prototypes don't need to be written with extern. extern is assumed by the compiler. Its use is as unnecessary as using auto to declare automatic/local variables in a block. Signed-off-by: Joe Perches Signed-off-by: David S. Miller