kernel.git/drivers/mtd/ubi/wl.c, branch linux-4.1.y

UBI: return ENOSPC if no enough space available

2015-10-22T21:43:24Z

commit 7c7feb2ebfc9c0552c51f0c050db1d1a004faac5 upstream. UBI: attaching mtd1 to ubi0 UBI: scanning is finished UBI error: init_volumes: not enough PEBs, required 706, available 686 UBI error: ubi_wl_init: no enough physical eraseblocks (-20, need 1) UBI error: ubi_attach_mtd_dev: failed to attach mtd1, error -12 <= NOT ENOMEM UBI error: ubi_init: cannot attach mtd1 If available PEBs are not enough when initializing volumes, return -ENOSPC directly. If available PEBs are not enough when initializing WL, return -ENOSPC instead of -ENOMEM. Signed-off-by: Sheng Yong Signed-off-by: Richard Weinberger Reviewed-by: David Gstir Signed-off-by: Greg Kroah-Hartman

UBI: Fastmap: Remove is_fm_block()

2015-03-26T21:47:38Z

This function was added to fastmap in a very early stage to have paranoid assertions. With the current fastmap implementation this assert will never trigger as fastmap PEBs are not seen by the WL sub-system. Remove it to save us some CPU cycles. Signed-off-by: Richard Weinberger

UBI: Fastmap: Introduce may_reserve_for_fm()

2015-03-26T21:47:36Z

...and kill another #ifdef. Signed-off-by: Richard Weinberger

UBI: Fastmap: Introduce ubi_fastmap_init()

2015-03-26T21:47:36Z

...and kill another #ifdef in wl.c. :-) Signed-off-by: Richard Weinberger

UBI: Move fastmap specific functions out of wl.c

2015-03-26T21:47:28Z

Fastmap is tightly connected to the WL sub-system, many fastmap-specific functionslive in wl.c. To get rid of most #ifdefs in wl.c move this functions into a new file and include it into wl.c Signed-off-by: Richard Weinberger

UBI: Fix stale pointers in ubi->lookuptbl

2015-03-26T21:46:04Z

In some error paths the WL sub-system gives up on a PEB and frees it's ubi_wl_entry struct but does not set the entry in ubi->lookuptbl to NULL. Fastmap can stumble over such a stale pointer as it uses ubi->lookuptbl to find all PEBs. Fix this by introducing a new helper function which free()s a WL entry and removes the reference from the lookup table. Signed-off-by: Richard Weinberger

UBI: Fastmap: Locking updates

2015-03-26T21:46:02Z

a) Rename ubi->fm_sem to ubi->fm_eba_sem as this semaphore protects EBA changes. b) Turn ubi->fm_mutex into a rw semaphore. It will still serialize fastmap writes but also ensures that ubi_wl_put_peb() is not interrupted by a fastmap write. We use a rw semaphore to allow ubi_wl_put_peb() still to be executed in parallel if no fastmap write is happening. Signed-off-by: Richard Weinberger

UBI: Fastmap: Fix race after ubi_wl_get_peb()

2015-03-26T21:46:01Z

ubi_wl_get_peb() returns a fresh PEB which can be used by user of UBI. Due to the pool logic fastmap will correctly map this PEB upon attach time because it will be scanned. If a new fastmap is written (due to heavy parallel io) while the before the fresh PEB is assigned to the EBA table it will not be scanned as it is no longer in the pool. So, the race window exists between ubi_wl_get_peb() and the EBA table assignment. We have to make sure that no new fastmap can be written while that. To ensure that ubi_wl_get_peb() will grab ubi->fm_sem in read mode and the user of ubi_wl_get_peb() has to release it after the PEB got assigned. Signed-off-by: Richard Weinberger

UBI: Fastmap: Notify user in case of an ubi_update_fastmap() failure

2015-03-26T21:45:55Z

If ubi_update_fastmap() fails notify the user. This is not a hard error as ubi_update_fastmap() makes sure that upon failure the current on-flash fastmap will no be used upon next UBI attach. Signed-off-by: Richard Weinberger

UBI: Fastmap: Fix memory leaks while closing the WL sub-system

2015-03-26T21:45:48Z

Add a ubi_fastmap_close() to free all resources used by fastmap at WL shutdown. Signed-off-by: Richard Weinberger Tested-by: Guido Martínez Reviewed-by: Guido Martínez