kernel.git/drivers/mtd/ubi/wl.c, branch linux-4.0.y

UBI: initialize LEB number variable

2015-05-06T20:03:52Z

commit f16db8071ce18819fbd705ddcc91c6f392fb61f8 upstream. In some of the 'out_not_moved' error paths, lnum may be used uninitialized. Don't ignore the warning; let's fix it. This uninitialized variable doesn't have much visible effect in the end, since we just schedule the PEB for erasure, and its LEB number doesn't really matter (it just gets printed in debug messages). But let's get it straight anyway. Coverity CID #113449 Signed-off-by: Brian Norris Signed-off-by: Richard Weinberger Signed-off-by: Greg Kroah-Hartman

UBI: extend UBI layer debug/messaging capabilities - cosmetics

2015-01-28T15:09:09Z

Some cosmetic fixes to the patch "UBI: Extend UBI layer debug/messaging capabilities". Signed-off-by: Tanya Brokhman Signed-off-by: Artem Bityutskiy

UBI: Fix double free after do_sync_erase()

2014-11-07T11:42:43Z

If the erase worker is unable to erase a PEB it will free the ubi_wl_entry itself. The failing ubi_wl_entry must not free()'d again after do_sync_erase() returns. Cc: Signed-off-by: Richard Weinberger Signed-off-by: Artem Bityutskiy

UBI: Extend UBI layer debug/messaging capabilities

2014-11-07T10:08:51Z

If there is more then one UBI device mounted, there is no way to distinguish between messages from different UBI devices. Add device number to all ubi layer message types. The R/O block driver messages were replaced by pr_* since ubi_device structure is not used by it. Amended a bit by Artem. Signed-off-by: Tanya Brokhman Signed-off-by: Artem Bityutskiy

UBI: Fix trivial typo in __schedule_ubi_work

2014-09-30T06:29:37Z

s/of/if/ Signed-off-by: Richard Weinberger Signed-off-by: Artem Bityutskiy

UBI: wl: Rename cancel flag to shutdown

2014-09-26T10:43:32Z

It confused me more than once that the cancel flag of the work function does not indicate the cancellation of a single work. In fact it indicates the WL sub-system shutdown and therefore worker functions have to free their wl_entries too. That's why you cannot cancel a single work, you can only shutdown all works. Signed-off-by: Richard Weinberger Signed-off-by: Artem Bityutskiy

UBI: Fix livelock in produce_free_peb()

2014-09-24T12:36:16Z

The while loop in produce_free_peb() assumes that each work will produce a free PEB. This is not true. If ubi->works_count is 1 and the only scheduled work is the wear_leveling_worker() produce_free_peb() can loop forever in case nobody schedules an erase work. Fix this issue by checking in the while loop whether work is scheduled. Signed-off-by: Richard Weinberger Signed-off-by: Artem Bityutskiy

UBI: bugfix in ubi_wl_flush()

2014-07-28T16:07:33Z

Use the _safe variant because we're iterating over a list where items get deleted and freed. Signed-off-by: Richard Weinberger Signed-off-by: Artem Bityutskiy

UBI: fix ubi free PEBs count calculation

2014-05-05T06:31:33Z

The ubi->free_count should be updated with every insert/remove to/from the ubi->free list. Signed-off-by: Tanya Brokhman Reviewed-by: Dolev Raviv Acked-by: Richard Weinberger Signed-off-by: Artem Bityutskiy

UBI: fix error path in __wl_get_peb

2014-05-05T06:31:33Z

In case of an error (if there are not free PEB's for example), __wl_get_peb will return a negative value. In order to prevent access violation we need to test the returned value prior to using it later on. Signed-off-by: Tatyana Brokhman Reviewed-by: Dolev Raviv Acked-by: Richard Weinberger Signed-off-by: Artem Bityutskiy