kernel.git/drivers/media/test-drivers, branch linux-6.4.y

media: Zero-initialize all structures passed to subdev pad operations

2023-04-12T07:46:06Z

Several drivers call subdev pad operations, passing structures that are not fully zeroed. While the drivers initialize the fields they care about explicitly, this results in reserved fields having uninitialized values. Future kernel API changes that make use of those fields thus risk breaking proper driver operation in ways that could be hard to detect. To avoid this, make the code more robust by zero-initializing all the structures passed to subdev pad operation. Maintain a consistent coding style by preferring designated initializers (which zero-initialize all the fields that are not specified) over memset() where possible, and make variable declarations local to inner scopes where applicable. One notable exception to this rule is in the ipu3 driver, where a memset() is needed as the structure is not a local variable but a function parameter provided by the caller. Not all fields of those structures can be initialized when declaring the variables, as the values for those fields are computed later in the code. Initialize the 'which' field in all cases, and other fields when the variable declaration is so close to the v4l2_subdev_call() call that it keeps all the context easily visible when reading the code, to avoid hindering readability. Signed-off-by: Laurent Pinchart Acked-by: Shuah Khan # For vimc Reviewed-by: Lad Prabhakar # For am437x Acked-by: Sakari Ailus Reviewed-by: Tomi Valkeinen Reviewed-by: Kieran Bingham Reviewed-by: Philipp Zabel # For drivers/staging/media/imx/ Signed-off-by: Hans Verkuil

media: vivid-core: Convert to platform remove callback returning void

2023-04-11T14:59:21Z

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Signed-off-by: Hans Verkuil

media: visl-core: Convert to platform remove callback returning void

2023-04-11T14:59:21Z

media: vimc-core: Convert to platform remove callback returning void

2023-04-11T14:59:21Z

media: vim2m: Convert to platform remove callback returning void

2023-04-11T14:59:21Z

media: vidtv_bridge: Convert to platform remove callback returning void

2023-04-11T14:59:21Z

media: vicodec-core: Convert to platform remove callback returning void

2023-04-11T14:59:21Z

media: vivid: drop bitmap and clipping output overlay support

2023-03-19T23:30:27Z

This test driver is the only remaining driver still using the clipping and bitmap method. Drop support for this so we can remove this in the V4L2 API as well. Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab

media: vivid: drop overlay support

2023-03-19T23:29:46Z

Destructive overlay support (i.e. where the video frame is DMA-ed straight into a framebuffer) is effectively dead. It was a necessary evil in the early days when computers were not fast enough to copy SDTV video frames around, but today that's no longer a problem. It requires access to the framebuffer memory, which is a bad idea and very hard to do safely. In addition, in drm it is today almost impossible to get hold of the framebuffer address. So drop support for this. Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab

media: visl: make visl_qops static

2023-02-08T07:29:53Z

This struct can be static. This fixes a sparse warning: visl-video.c:690:22: warning: symbol 'visl_qops' was not declared. Should it be static? Signed-off-by: Hans Verkuil Cc: Daniel Almeida Signed-off-by: Mauro Carvalho Chehab