kernel.git/drivers/media/platform/ti, branch linux-6.4.y

media: Prefer designated initializers over memset for subdev pad ops

2023-04-12T07:46:06Z

Structures passed to subdev pad operations are all zero-initialized, but not always with the same kind of code constructs. While most drivers used designated initializers, which zero all the fields that are not specified, when declaring variables, some use memset(). Those two methods lead to the same end result, and, depending on compiler optimizations, may even be completely equivalent, but they're not consistent. Improve coding style consistency by using designated initializers instead of calling memset(). Where applicable, also move the variables to inner scopes of for loops to ensure correct initialization in all iterations. Signed-off-by: Laurent Pinchart Reviewed-by: Lad Prabhakar # For am437x Acked-by: Sakari Ailus Reviewed-by: Tomi Valkeinen Reviewed-by: Kieran Bingham Reviewed-by: Philipp Zabel Signed-off-by: Hans Verkuil

media: Zero-initialize all structures passed to subdev pad operations

2023-04-12T07:46:06Z

Several drivers call subdev pad operations, passing structures that are not fully zeroed. While the drivers initialize the fields they care about explicitly, this results in reserved fields having uninitialized values. Future kernel API changes that make use of those fields thus risk breaking proper driver operation in ways that could be hard to detect. To avoid this, make the code more robust by zero-initializing all the structures passed to subdev pad operation. Maintain a consistent coding style by preferring designated initializers (which zero-initialize all the fields that are not specified) over memset() where possible, and make variable declarations local to inner scopes where applicable. One notable exception to this rule is in the ipu3 driver, where a memset() is needed as the structure is not a local variable but a function parameter provided by the caller. Not all fields of those structures can be initialized when declaring the variables, as the values for those fields are computed later in the code. Initialize the 'which' field in all cases, and other fields when the variable declaration is so close to the v4l2_subdev_call() call that it keeps all the context easily visible when reading the code, to avoid hindering readability. Signed-off-by: Laurent Pinchart Acked-by: Shuah Khan # For vimc Reviewed-by: Lad Prabhakar # For am437x Acked-by: Sakari Ailus Reviewed-by: Tomi Valkeinen Reviewed-by: Kieran Bingham Reviewed-by: Philipp Zabel # For drivers/staging/media/imx/ Signed-off-by: Hans Verkuil

media: vpe: Convert to platform remove callback returning void

2023-04-11T14:59:19Z

The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Signed-off-by: Hans Verkuil

media: isp: Convert to platform remove callback returning void

2023-04-11T14:59:19Z

media: omap_vout: Convert to platform remove callback returning void

2023-04-11T14:59:19Z

media: vpif_display: Convert to platform remove callback returning void

2023-04-11T14:59:19Z

media: vpif_capture: Convert to platform remove callback returning void

2023-04-11T14:59:19Z

media: vpif: Convert to platform remove callback returning void

2023-04-11T14:59:19Z

media: cal: Convert to platform remove callback returning void

2023-04-11T14:59:19Z

media: am437x-vpfe: Convert to platform remove callback returning void

2023-04-11T14:59:19Z