kernel.git/drivers/media/IR/lirc_dev.c, branch linux-2.6.37.yHosts the 0x221E linux distro kernel.
https://git.0xinfinity.dev/distro/kernel.git/atom?h=linux-2.6.37.y2010-12-20T16:11:15Z[media] lirc_dev: fixes in lirc_dev_fop_read()2010-12-20T16:11:15ZDan Carpenter2010-11-17T05:20:15Zurn:sha1:250f7a5f62a08985af5cf7728ae7ba9edbfdc0a9
This makes several changes but they're in one function and sort of
related:
"buf" was leaked on error. The leak if we try to read an invalid
length is the main concern because it could be triggered over and
over.
If the copy_to_user() failed, then the original code returned the
number of bytes remaining. read() is supposed to be the opposite way,
where we return the number of bytes copied. I changed it to just return
-EFAULT on errors.
Also I changed the debug output from "-EFAULT" to just "<fail>" because
it isn't -EFAULT necessarily. And since we go though that path if the
length is invalid now, there was another debug print that I removed.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Jarod Wilson <jarod@redhat.com>
Acked-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
[media] lirc_dev: stray unlock in lirc_dev_fop_poll()2010-12-20T16:11:14ZDan Carpenter2010-11-17T05:12:23Zurn:sha1:5c769a68beaee924e1dc90bf06e1b087b1d46237
We shouldn't unlock here. I think this was a cut and paste error.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Merge branch 'v4l_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.62010-10-28T16:35:11ZLinus Torvalds2010-10-28T16:35:11Zurn:sha1:0851668fdd97e526b2a41f794b785c204dd3d3e0
* 'v4l_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6: (505 commits)
[media] af9015: Fix max I2C message size when used with tda18271
[media] IR: initialize ir_raw_event in few more drivers
[media] Guard a divide in v4l1 compat layer
[media] imon: fix nomouse modprobe option
[media] imon: remove redundant change_protocol call
[media] imon: fix my egregious brown paper bag w/rdev/idev split
[media] cafe_ccic: Configure ov7670 correctly
[media] ov7670: allow configuration of image size, clock speed, and I/O method
[media] af9015: support for DigitalNow TinyTwin v3 [1f4d:9016]
[media] af9015: map DigitalNow TinyTwin v2 remote
[media] DigitalNow TinyTwin remote controller
[media] af9015: RC fixes and improvements
videodev2.h.xml: Update to reflect the latest changes at videodev2.h
[media] v4l: document new Bayer and monochrome pixel formats
[media] DocBook/v4l: Add missing formats used on gspca cpia1 and sn9c2028
[media] firedtv: add parameter to fake ca_system_ids in CA_INFO
[media] tm6000: fix a macro coding style issue
tm6000: Remove some ugly debug code
[media] Nova-S-Plus audio line input
[media] [RFC,1/1] V4L2: Use new CAP bits in existing RDS capable drivers
...
Remove duplicate includes from many files2010-10-28T01:03:18ZZimny Lech2010-10-27T22:34:53Zurn:sha1:61d8e11e519ee7912ab59610fba1aaf08e3c1d84
Signed-off-by: Zimny Lech <napohybelskurwysynom2010@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
[media] lirc_dev: rework storage for cdev data2010-10-22T22:05:36ZJarod Wilson2010-10-18T21:39:20Zurn:sha1:c1cbb7029e81894c056680d61c64741bd2ff246f
Fixes an oops when an lirc driver that doesn't provide its own fops is
unplugged while the lirc cdev is open. Tested with lirc_igorplugusb,
with a special thanks to Timo Boettcher for providing the test hardware.
Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
[media] lirc_dev: call cdev_del *after* irctl cleanup2010-10-22T22:05:36ZJarod Wilson2010-10-18T20:30:20Zurn:sha1:09c8dd8de67cf781be95d809cd45af22f40c37df
Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
[media] lirc_dev: more error-checking improvements2010-10-22T22:05:36ZJarod Wilson2010-10-18T15:02:01Zurn:sha1:715d29a74450696696dc064f85ba4ff0eaadb1d2
Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
[media] lirc_dev: get irctl from irctls by inode again2010-10-22T22:05:36ZJarod Wilson2010-10-17T00:36:43Zurn:sha1:d889a135cb832c77b7f90a89b40090e4e9ba609b
Can't explain it (yet), but I've seen the 'get irctl via private_data'
setup fail for a number of people (ioctl called before its filled in?),
so lets go back to a variant of the old way, but one that still works
with unlocked_ioctl.
Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
[media] lirc_dev: fix pointer to owner2010-10-22T22:05:35ZJarod Wilson2010-10-17T00:32:44Zurn:sha1:90dc4cfa2076cdc4df4c2f5dd3cadeefd9557c2c
If an lirc device driver doesn't specify its own fops, we set set
ir->cdev.owner to THIS_MODULE. If it does specify its own fops, we
set ir->cdev.owner to ir->d.owner. Subsequent module_{get,put} calls
should be using ir->cdev.owner, not ir->d.owner.
Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
[media] lirc_dev: sanitize function and struct names a bit2010-10-22T22:05:35ZJarod Wilson2010-10-17T00:29:50Zurn:sha1:578fcb8e5f3046493932105c404792a2fe0e066f
Use names that clearly identify functions as lirc functions.
Signed-off-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>