kernel.git/drivers/md/bcache/btree.c, branch linux-4.0.y

bcache: try to set b->parent properly

2014-08-04T22:23:04Z

bcache_flash_dev.ktest would reliably crash with 8k and 16k bucket size before; now it passes. Change-Id: Ib542232235e39298c3a7548fe52b645cabb823d1

bcache: fix use-after-free in btree_gc_coalesce()

2014-08-04T22:23:04Z

If we goto out_nocoalesce after we free new_nodes[0], we end up freeing new_nodes[0] again. This was generating a lockdep warning. The fix is to set new_nodes[0] to NULL, since the out_nocoalesce path safely ignores NULL entries in the new_nodes array. This regression was introduced in 2d7f9531. Change-Id: I76564d7257800583214376b4bacf236cda90c89c

bcache: fix crash in bcache_btree_node_alloc_fail tracepoint

2014-08-04T22:23:03Z

'b' was NULL. Change-Id: Icac0fd04afa2d23f213d96d51afd53374e6dd0c0

bcache: Allocate bounce buffers with GFP_NOWAIT

2014-08-04T22:23:03Z

There's no point in blocking on these allocations, since our fallback paths will probably go faster than blocking. Change-Id: I733ca202c25cb36bde02607a0a60552229a4241c

bcache: Make sure to pass GFP_WAIT to mempool_alloc()

2014-08-04T22:23:03Z

this was very wrong - mempool_alloc() only guarantees success with GFP_WAIT. bcache uses GFP_NOWAIT in various other places where we have a fallback, circuits must've gotten crossed when writing this code or something. Signed-off-by: Kent Overstreet

bcache: wait for buckets when allocating new btree root

2014-08-04T22:23:03Z

Tested: - sometimes bcache_tier test would hang on startup with a failure to allocate the btree root -- no longer seeing this Signed-off-by: Kent Overstreet

bcache: Kill bucket->gc_gen

2014-03-18T19:24:54Z

gc_gen was a temporary used to recalculate last_gc, but since we only need bucket->last_gc when gc isn't running (gc_mark_valid = 1), we can just update last_gc directly. Signed-off-by: Kent Overstreet

bcache: Kill unused freelist

2014-03-18T19:23:36Z

This was originally added as at optimization that for various reasons isn't needed anymore, but it does add a lot of nasty corner cases (and it was responsible for some recently fixed bugs). Just get rid of it now. Signed-off-by: Kent Overstreet

bcache: Rework btree cache reserve handling

2014-03-18T19:23:35Z

This changes the bucket allocation reserves to use _real_ reserves - separate freelists - instead of watermarks, which if nothing else makes the current code saner to reason about and is going to be important in the future when we add support for multiple btrees. It also adds btree_check_reserve(), which checks (and locks) the reserves for both bucket allocation and memory allocation for btree nodes; the old code just kinda sorta assumed that since (e.g. for btree node splits) it had the root locked and that meant no other threads could try to make use of the same reserve; this technically should have been ok for memory allocation (we should always have a reserve for memory allocation (the btree node cache is used as a reserve and we preallocate it)), but multiple btrees will mean that locking the root won't be sufficient anymore, and for the bucket allocation reserve it was technically possible for the old code to deadlock. Signed-off-by: Kent Overstreet

bcache: Kill btree_io_wq

2014-03-18T19:23:35Z

With the locking rework in the last patch, this shouldn't be needed anymore - btree_node_write_work() only takes b->write_lock which is never held for very long. Signed-off-by: Kent Overstreet