kernel.git/drivers/iio/humidity/hts221_buffer.c, branch linux-5.4.y

iio:humidity:hts221 Fix alignment and data leak issues

2020-07-22T07:32:54Z

commit 5c49056ad9f3c786f7716da2dd47e4488fc6bd25 upstream. One of a class of bugs pointed out by Lars in a recent review. iio_push_to_buffers_with_timestamp assumes the buffer used is aligned to the size of the timestamp (8 bytes). This is not guaranteed in this driver which uses an array of smaller elements on the stack. As Lars also noted this anti pattern can involve a leak of data to userspace and that indeed can happen here. We close both issues by moving to a suitable structure in the iio_priv() data. This data is allocated with kzalloc so no data can leak apart from previous readings. Explicit alignment of ts needed to ensure consistent padding on all architectures (particularly x86_32 with it's 4 byte alignment of s64) Fixes: e4a70e3e7d84 ("iio: humidity: add support to hts221 rh/temp combo device") Reported-by: Lars-Peter Clausen Acked-by: Lorenzo Bianconi Signed-off-by: Jonathan Cameron Cc: Signed-off-by: Greg Kroah-Hartman

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 177

2019-05-30T18:29:19Z

Based on 1 normalized pattern(s): licensed under the gpl 2 extracted by the scancode license scanner the SPDX license identifier GPL-2.0-only has been chosen to replace the boilerplate/reference in 135 file(s). Signed-off-by: Thomas Gleixner Reviewed-by: Allison Randal Reviewed-by: Richard Fontana Reviewed-by: Alexios Zavras Reviewed-by: Steve Winslow Cc: linux-spdx@vger.kernel.org Link: https://lkml.kernel.org/r/20190528170026.071193225@linutronix.de Signed-off-by: Greg Kroah-Hartman

iio: humidity: hts221: add regmap API support

2018-01-30T18:33:18Z

Introduce regmap API support to access to i2c/spi bus instead of using a custom support. Remove lock mutex since concurrency is already managed by regmap API Signed-off-by: Lorenzo Bianconi Signed-off-by: Jonathan Cameron

iio: humidity: hts221: remove trailing whitespace from a comment

2018-01-30T18:33:16Z

Signed-off-by: Lorenzo Bianconi Signed-off-by: Jonathan Cameron

iio:humidity: drop assign iio_info.driver_module and iio_trigger_ops.owner

2017-08-22T20:30:20Z

The equivalent of both of these are now done via macro magic when the relevant register calls are made. The actual structure elements will shortly go away. Signed-off-by: Jonathan Cameron Reviewed-by: Lars-Peter Clausen

iio: humidity: hts221: move drdy enable logic in hts221_trig_set_state()

2017-07-25T19:03:04Z

Move data-ready configuration in hts221_buffer.c since it is only related to trigger logic Signed-off-by: Lorenzo Bianconi Signed-off-by: Jonathan Cameron

iio: humidity: hts221: support open drain mode

2017-07-25T19:00:47Z

Add open drain support in order to share requested IRQ line between hts221 device and other peripherals Signed-off-by: Lorenzo Bianconi Signed-off-by: Jonathan Cameron

iio: humidity: hts221: support active-low interrupts

2017-07-22T20:21:46Z

Add support for active low interrupts (IRQF_TRIGGER_LOW and IRQF_TRIGGER_FALLING). Configure the device as active high or low according to the requested irq line. Signed-off-by: Lorenzo Bianconi Signed-off-by: Jonathan Cameron

iio: humidity: hts221: squash hts221_power_on/off in hts221_set_enable

2017-07-22T20:20:48Z

Signed-off-by: Lorenzo Bianconi Signed-off-by: Jonathan Cameron

iio: humidity: hts221: Remove unnecessary cast on void pointer

2017-04-02T08:50:32Z

The following Coccinelle script was used to detect this: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x)[...] | ((T*)x)->f | - (T*) e ) Signed-off-by: simran singhal Signed-off-by: Jonathan Cameron