kernel.git/drivers/hwmon/max6650.c, branch linux-5.12.y

hwmon: (max6650) Switch to using the new API kobj_to_dev()

2021-01-28T01:44:18Z

Switch to using the new API kobj_to_dev() to fix the below warnning: drivers/hwmon/max6650.c:324:60-61: WARNING opportunity for kobj_to_dev(). Signed-off-by: Tian Tao Link: https://lore.kernel.org/r/1609376621-46463-1-git-send-email-tiantao6@hisilicon.com Signed-off-by: Guenter Roeck

hwmon: use simple i2c probe function

2020-09-23T16:42:39Z

Many hwmon drivers don't use the id information provided by the old i2c probe function, and the remainder can easily be adapted to the new form ("probe_new") by calling i2c_match_id explicitly. This avoids scanning the identifier tables during probes. Drivers which didn't use the id are converted as-is; drivers which did are modified as follows: * if the information in i2c_client is sufficient, that's used instead (client->name); * anything else is handled by calling i2c_match_id() with the same level of error-handling (if any) as before. A few drivers aren't included in this patch because they have a different set of maintainers. They will be covered by other patches. Signed-off-by: Stephen Kitt Link: https://lore.kernel.org/r/20200813160222.1503401-1-steve@sk2.org Signed-off-by: Guenter Roeck

hwmon: (max6650) Fix unused variable warning

2019-06-24T01:33:01Z

The newly added variable is only used in an #if block: drivers/hwmon/max6650.c: In function 'max6650_probe': drivers/hwmon/max6650.c:766:33: error: unused variable 'cooling_dev' [-Werror=unused-variable] Change the #if to if() so the compiler can see what is actually going on. Fixes: a8463754a5a9 ("hwmon: (max6650) Use devm function to register thermal device") Signed-off-by: Arnd Bergmann Signed-off-by: Guenter Roeck

hwmon: (max6650) Fix minor formatting issues

2019-06-24T01:33:01Z

CHECK: struct mutex definition without comment CHECK: Alignment should match open parenthesis Cc: Jean-Francois Dagenais Signed-off-by: Guenter Roeck

hwmon: (max6650) Improve error handling in max6650_update_device

2019-06-24T01:33:01Z

Pass errors from i2c_smbus_read_byte_data() back to the caller of max6650_update_device(). Cc: Jean-Francois Dagenais Signed-off-by: Guenter Roeck

hwmon: (max6650) Read non-volatile registers only once

2019-06-24T01:33:01Z

Only tachometer and alarm status registers are modified by the chip. All other registers only need to be read only once, and reading them repeatedly does not add any value. Cc: Jean-Francois Dagenais Signed-off-by: Guenter Roeck

hwmon: (max6650) Convert to use devm_hwmon_device_register_with_info

2019-06-24T01:33:01Z

Convert driver to use devm_hwmon_device_register_with_info to simplify the code and to reduce its size. Cc: Jean-Francois Dagenais Signed-off-by: Guenter Roeck

hwmon: (max6650) Simplify alarm handling

2019-06-24T01:33:01Z

Instead of re-reading the alarm register after reporting an alarm, mark cached values as invalid. While this results in always reading all data on subsequent reads, it is quite unlikely that such reads will actually happen before the cache times out. The upside is avoiding unnecessary unconditional i2c read operations. Cc: Jean-Francois Dagenais Signed-off-by: Guenter Roeck

hwmon: (max6650) Cache alarm_en register

2019-06-24T01:33:01Z

The alarm_en register is read each time the is_visible function is called. Since it is a configuration register, this is completely unnecessary. Read it once and cache its value. Cc: Jean-Francois Dagenais Signed-off-by: Guenter Roeck

hwmon: (max6650) Declare valid as boolean

2019-06-24T01:33:01Z

Declare valid as boolean to match its use case. Cc: Jean-Francois Dagenais Signed-off-by: Guenter Roeck