kernel.git/drivers/hwmon/it87.c, branch linux-4.10.y

hwmon: (it87) Fix pwm4 detection for IT8620 and IT8628

2017-05-14T12:08:19Z

commit d66777caa57ffade6061782f3a4d4056f0b0c1ac upstream. pwm4 is enabled if bit 2 of GPIO control register 4 is disabled, not when it is enabled. Since the check is for the skip condition, it is reversed. This applies to both IT8620 and IT8628. Fixes: 36c4d98a7883d ("hwmon: (it87) Add support for all pwm channels ...") Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman

hwmon: (it87) Avoid registering the same chip on both SIO addresses

2017-05-08T05:49:43Z

commit 8358378b22518d92424597503d3c1cd302a490b6 upstream. IT8705F is known to respond on both SIO addresses. Registering it twice may result in system lockups. Reported-by: Russell King Fixes: e84bd9535e2b ("hwmon: (it87) Add support for second Super-IO chip") Signed-off-by: Guenter Roeck Cc: Jean Delvare Signed-off-by: Greg Kroah-Hartman

hwmon: (it87) Ensure that pwm control cache is current before updating values

2017-03-12T05:44:08Z

commit 82dbe987b70042b340f851bdc969a971081e5f02 upstream. If sensor attributes were never read, the pwm control data has not been initiialized, which can cause wrong driver behavior. Ensure that cached data is current before acting on it. Reported-by: Kevin Folz Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman

hwmon: (it87) Do not overwrite bit 2..6 of pwm control registers

2017-03-12T05:44:08Z

commit 4c7b8ca1ae5ed9e27014732c8a918ba11a86cf09 upstream. In IT8620E, after setting pwm control to manual, it was observed that pwm values for fan 4..6 have reversed results (writing 0 results in fans running at full speed, writing 255 results in fans turned off). With the new PWM control, pwm polarity for pwm control 4..6 is specified in its pwm control registers. Those registers are overwritten when setting the pwm mode or the temperature mapping. Do not touch bit 2..6 of pwm control registers on register writes to fix the problem. Signed-off-by: Guenter Roeck Signed-off-by: Greg Kroah-Hartman

hwmon: (it87) Drop useless comments

2016-09-09T04:34:17Z

Remove the index comments at the end of it87_attributes_in. They serve no purpose (as there is no reference to them in it87_in_is_visible) and some of them were obviously wrong. Signed-off-by: Jean Delvare Cc: Martin Blumenstingl Cc: Guenter Roeck Signed-off-by: Guenter Roeck

hwmon: (it87) Add missing sysfs attribute group terminator

2016-08-29T12:31:31Z

Attribute array it87_attributes_in lacks its NULL terminator, causing random behavior when operating on the attribute group. Fixes: 52929715634a ("hwmon: (it87) Use is_visible for voltage sensors") Signed-off-by: Jean Delvare Cc: Martin Blumenstingl Cc: Guenter Roeck Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck

hwmon: (it87) Features mask must be 32 bit wide

2016-08-12T01:35:47Z

Coverity reports: result_independent_of_operands: data->features & (65536UL /* 1UL << 16 */) is always 0 regardless of the values of its operands. This occurs as the logical operand of if. data->features needs to be 32 bit wide since there are more than 16 features. Fixes: cc18da79d9b7 ("hwmon: (it87) Support up to 6 temperature sensors ... "); Signed-off-by: Guenter Roeck

hwmon: (it87) Add support for IT8628E

2016-04-19T13:32:38Z

IT8628E is functionally identical to IT8620E. Tested-by: Martin Blumenstingl Signed-off-by: Guenter Roeck

hwmon: (it87) Fix pwm_temp_map for system with 6 pwm channels

2016-04-19T13:32:37Z

Tested-by: Martin Blumenstingl Signed-off-by: Guenter Roeck

hwmon: (it87) Support automatic pwm control on newer chips

2016-04-19T13:32:37Z

Tested-by: Martin Blumenstingl Signed-off-by: Guenter Roeck