kernel.git/drivers/hwmon/hwmon.c, branch linux-4.13.y

hwmon: Constify str parameter of hwmon_ops->read_string

2017-04-02T14:01:53Z

The read_string callback is supposed to retrieve a pointer to a constant string. Signed-off-by: Jean Delvare Reviewed-by: Peter Huewe Signed-off-by: Guenter Roeck

hwmon: Register thermal zone only if 'dev' parameter was provided

2017-01-31T11:56:08Z

Rgistering a thermal zone uses devm_kzalloc(), which requires a pointer to the parent device. Reported-by: Dan Carpenter Signed-off-by: Guenter Roeck

hwmon: Relax name attribute validation for new APIs

2017-01-31T11:52:15Z

While invalid name attributes are really not desirable and do mess up libsensors, enforcing valid names has the detrimental effect of driving users away from using the new hardware monitoring API, especially those registering name attributes violating the ABI restrictions. Another undesirable side effect is that this violation and the resulting error may only be discovered some time after a conversion to the new API, which in turn may trigger a revert of that conversion. To solve the problem, relax validation and only issue a warning instead of returning an error if a name attribute violating the ABI is provided. This lets callers continue to provide invalid name attributes while notifying them about it. Many thanks are due to Dmitry Torokhov for the idea. Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: Make name attribute mandatory for new APIs

2017-01-25T14:14:26Z

It does not make sense to use one of the the new APIs when not even providing a name attribute. Make it mandatory. Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: (core) use permission-specific DEVICE_ATTR variants

2017-01-02T18:19:45Z

Use DEVICE_ATTR_RO for read-only attributes. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The conversion was done automatically using coccinelle. It was validated by compiling both the old and the new source code and comparing its text, data, and bss size. Signed-off-by: Julia Lawall [groeck: Updated description] Signed-off-by: Guenter Roeck

hwmon: (core) Simplify sysfs attribute name allocation

2016-12-10T05:54:24Z

Allocating the sysfs attribute name only if needed and only with the required minimum length looks optimal, but does not take the additional overhead for both devm_ data structures and the allocation header itself into account. This also results in unnecessary memory fragmentation. Move the sysfs name string into struct hwmon_device_attribute and give it a sufficient length to reduce this overhead. Signed-off-by: Guenter Roeck

hwmon: (core) Rename groups parameter in API to extra_groups

2016-12-10T05:54:22Z

The 'groups' parameter of hwmon_device_register_with_info() and devm_hwmon_device_register_with_info() is only necessary if extra non-standard attributes need to be provided. Rename the parameter to extra_groups and clarify the documentation. Signed-off-by: Guenter Roeck

hwmon: (core) Explain why at least two attribute groups are allocated

2016-12-10T05:54:21Z

A list of sysfs attribute groups is NULL-terminated, so we always need to allocate data for at least two groups (the dynamically generated group plus the NULL pointer). Add a comment to explain the situation. Signed-off-by: Guenter Roeck

hwmon: (core) Make is_visible callback truly mandatory

2016-12-10T05:54:20Z

The is_visible callback provides the sysfs attribute mode and is thus truly mandatory as documented. Check it once at registration and remove other checks for its existence. Signed-off-by: Guenter Roeck

hwmon: (core) Deprecate hwmon_device_register()

2016-12-10T05:54:19Z

Inform the user that hwmon_device_register() is deprecated, and suggest conversion to the newest API. Also remove hwmon_device_register() from the kernel API documentation. Note that hwmon_device_register() is not marked as __deprecated() since doing so might result in build errors. Signed-off-by: Guenter Roeck