kernel.git/drivers/hwmon/emc2103.c, branch linux-5.1.y

hwmon: (emc2103) Use permission specific SENSOR[_DEVICE]_ATTR variants

2018-12-16T23:13:44Z

Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code, to improve readbility, and to reduce the chance of inconsistencies. Also replace any remaining S_ in the driver with octal values. The conversion was done automatically with coccinelle. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches/hwmon/. This patch does not introduce functional changes. It was verified by compiling the old and new files and comparing text and data sizes. Cc: Steve Glendinning Signed-off-by: Guenter Roeck

hwmon: (emc2103) use permission-specific DEVICE_ATTR variants

2017-01-02T18:19:45Z

Use DEVICE_ATTR_RO for read only attributes and DEVICE_ATTR_RW for read/write attributes. This simplifies the source code, improves readbility, and reduces the chance of inconsistencies. The conversion was done automatically using coccinelle. It was validated by compiling both the old and the new source code and comparing its text, data, and bss size. Signed-off-by: Julia Lawall [groeck: Updated description] Signed-off-by: Guenter Roeck

hwmon: (emc2103) Fix overflows seen when temperature limit attributes

2016-12-12T19:33:43Z

Writes into temperature limit attributes can overflow due to unbound values passed to DIV_ROUND_CLOSEST(). Cc: Steve Glendinning Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: (emc2103) Fix typo in MODULE_PARM_DESC

2016-05-26T09:06:53Z

"apd" was intended here instead of "init". Signed-off-by: Dan Carpenter Signed-off-by: Jean Delvare

hwmon: (emc2103) Convert to devm_hwmon_device_register_with_groups

2014-08-04T14:01:40Z

Use devm_hwmon_device_register_with_groups() to simplify the code a bit. Signed-off-by: Axel Lin Signed-off-by: Guenter Roeck

hwmon: (emc2103) Clamp limits instead of bailing out

2014-07-07T14:15:31Z

It is customary to clamp limits instead of bailing out with an error if a configured limit is out of the range supported by the driver. This simplifies limit configuration, since the user will not typically know chip and/or driver specific limits. Reviewed-by: Jean Delvare Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck

hwmon: (emc2103) Return error from i2c_smbus_read_byte_data

2014-03-03T16:01:04Z

There is no reason to replace one error with another. smatch message: drivers/hwmon/emc2103.c:352 set_fan_div() info: why not propagate 'status' from i2c_smbus_read_byte_data() instead of (-5)? Reviewed-by: Jean Delvare Signed-off-by: Guenter Roeck

hwmon: (emc2103) Fix return value

2013-09-11T20:01:31Z

kstrtol() returns appropriate error values. Use those instead of hardcoding. Silences several sparse messages of following type: "why not propagate 'result' from kstrtol() instead of (-22)?" Signed-off-by: Sachin Kamat Cc: Steve Glendinning Signed-off-by: Guenter Roeck

hwmon: Replace SENSORS_LIMIT with clamp_val

2013-01-26T05:03:54Z

SENSORS_LIMIT and the generic clamp_val have the same functionality, and clamp_val is more efficient. This patch reduces text size by 9052 bytes and bss size by 11624 bytes for x86_64 builds. Signed-off-by: Guenter Roeck Acked-by: George Joseph Acked-by: Jean Delvare

hwmon: (emc2103) Convert to use devm_ functions

2012-09-24T04:08:31Z

Convert to use devm_ functions to reduce code size and simplify the code. Cc: Steve Glendinning Signed-off-by: Guenter Roeck