kernel.git/drivers/hwmon/coretemp.c, branch linux-2.6.37.y

hwmon: (coretemp) fix reading of microcode revision (v2)

2010-10-25T21:11:21Z

According to the documentation, simply reading the respective MSR isn't sufficient: It should be written with zeros, cpuid(1) be executed, and then read (see arch/x86/kernel/cpu/intel.c for an example). v2: Fail probe when microcode revision cannot be determined, but is needed to check for proper operation. Signed-off-by: Jan Beulich Cc: Fenghua Yu Cc: Chen Gong Cc: Jean Delvare Acked-by: Fenghua Yu Signed-off-by: Guenter Roeck

hwmon: ({core, pkg, via-cpu}temp) remove unnecessary CONFIG_HOTPLUG_CPU ifdefs

2010-10-25T21:11:21Z

CONFIG_HOTPLUG_CPU is used too much in some drivers. This patch clean them up. Signed-off-by: Chen Gong Signed-off-by: Guenter Roeck

x86/hwmon: remove inclusion of unnecessary headers from {core, pkg, via-cpu}temp.c

2010-10-25T21:11:20Z

These likely originate from these drivers being clones of one another and/or other drivers which actually needed these includes. Signed-off-by: Jan Beulich Signed-off-by: Guenter Roeck

x86/hwmon: (coretemp) cosmetic cleanup

2010-10-25T21:11:20Z

"break" after "return" is at best bogus (good compilers even warn about the "break" being unreachable). Signed-off-by: Jan Beulich Cc: Rudolf Marek Signed-off-by: Guenter Roeck

x86/hwmon: {core, pkg, via}cpu_temp_device_remove() can all be __cpuinit

2010-10-25T21:11:19Z

... as they're being called only from a __cpuinit function. Signed-off-by: Jan Beulich Signed-off-by: Guenter Roeck

hwmon (coretemp): Fix build breakage if SMP is undefined

2010-09-28T11:18:51Z

Commit e40cc4bdfd4b89813f072f72bd9c7055814d3f0f introduced a build breakage if CONFIG_SMP is undefined. This commit fixes the problem. This fix is only a workaround. For a real fix, cpu_sibling_mask() should be defined in UP include code, eg in linux/smp.h, and asm/smp.h should not be included directly. This fix is currently not possible because asm/smp.h defines cpu_sibling_mask() unconditionally and is included directly from many source files. Reported-by: Ingo Molnar Tested-by: Ingo Molnar Signed-off-by: Guenter Roeck Cc: Fenghua Yu

x86/hwmon: register alternate sibling upon CPU removal

2010-09-24T18:44:19Z

Just like pkgtemp registers another core of the same package when one gets removed, coretemp should register another hyperthread (if available) in that situation. As pointed out in the patch fixing the respective code in pkgtemp, the list protectng mutex must be dropped before calling coretemp_device_add(), and due to the restructured loop (including an explicit return) the "safe" variant of the list iterator isn't needed anymore. Signed-off-by: Jan Beulich Cc: Rudolf Marek Signed-off-by: Guenter Roeck

x86/hwmon: fix initialization of coretemp

2010-09-24T18:44:19Z

Using cpuid_eax() to determine feature availability on other than the current CPU is invalid. And feature availability should also be checked in the hotplug code path. Signed-off-by: Jan Beulich Cc: Rudolf Marek Cc: Fenghua Yu Signed-off-by: Guenter Roeck

x86/hwmon: fix module init for hotplug-but-no-device-found case

2010-09-24T18:44:18Z

In commit 0dca94baeab4a1a514841b0a4c8e3a51dfb4d5ae the call to platform_driver_unregister() was made conditional upon !HOTPLUG_CPU, but the return value from coretemp_init() was left to indicate an error. This isn't correct, as the negative return value indicates to the module loader that initialization failed, which isn't intended here and results in dangling pointers. Signed-off-by: Jan Beulich Cc: Chen Gong Signed-off-by: Guenter Roeck

hwmon: (coretemp) Fix harmless build warning

2010-08-25T13:42:08Z

Fix the following build warning: CC [M] drivers/hwmon/coretemp.o drivers/hwmon/coretemp.c: In function "coretemp_init": drivers/hwmon/coretemp.c:521: warning: unused variable "n" drivers/hwmon/coretemp.c:521: warning: unused variable "p" Introduced by commit 851b29cb3b196cb66452ec964ab5f66c9c9cd1ed. When you drop code, you also have to drop the variables this code was using. Signed-off-by: Jean Delvare Cc: Chen Gong Cc: Rudolf Marek Cc: Huaxu Wan