kernel.git/drivers/gpu/drm/tegra/hdmi.c, branch linux-6.5.yHosts the 0x221E linux distro kernel.
https://git.0xinfinity.dev/distro/kernel.git/atom?h=linux-6.5.y2023-04-04T12:24:41Zdrm/tegra: hdmi: Convert to platform remove callback returning void2023-04-04T12:24:41ZUwe Kleine-König2023-03-22T17:02:19Zurn:sha1:4ef19206b23b49041a3eeb4ea132a213e4f7b78c
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thierry Reding <treding@nvidia.com>
gpu: host1x: Make host1x_client_unregister() return void2023-04-04T11:59:10ZUwe Kleine-König2023-03-22T17:02:12Zurn:sha1:1d83d1a2df0bfb6bd79400746c289e2c4edc5909
This function returned zero unconditionally. Make it return no value and
simplify all callers accordingly.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drm/tegra: Convert to using is_hdmi from display info2022-11-25T15:14:58ZJani Nikula2022-09-01T12:47:06Zurn:sha1:17c2984492c4b4fb130c50c85d48d382cbb9471f
Prefer the parsed results for is_hdmi in display info over calling
drm_detect_hdmi_monitor().
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-tegra@vger.kernel.org
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drm/tegra: Use dev_err_probe()2022-02-24T16:03:08ZDmitry Osipenko2022-02-07T21:29:23Zurn:sha1:f07f04a51d92165e0ad711f1be1cc5bbbfcb4766
Replace dev_printk() with a generic dev_err_probe() helper which silences
noisy error messages about deferred probe and makes easy to debug failing
deferred probe by printing notification about the failure to KMSG in the
end of kernel booting process and by adding failing device and the reason
of deferred probe to devices_deferred of debugfs. This was proven to be
useful in the case of eDP driver regression by immediately showing why
display driver was failing when user asked for help, otherwise it would've
been much more difficult to debug such problems on a third party device
that doesn't have developer setup.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drm/tegra: hdmi: Add OPP support2021-12-16T13:07:07ZDmitry Osipenko2021-11-30T23:23:19Zurn:sha1:6efdde0cd08b8fe79f20e2c150260f19e762e4d0
The HDMI on Tegra belongs to the core power domain and we're going to
enable GENPD support for the core domain. Now HDMI driver must use
OPP API for driving the controller's clock rate because OPP API takes
care of reconfiguring the domain's performance state based on HDMI clock
rate. Add OPP support to the HDMI driver.
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drm/tegra: hdmi: Register audio CODEC on Tegra202021-12-16T13:07:07ZDmitry Osipenko2021-12-04T14:37:18Zurn:sha1:20c5a613185c98068e9ee5b011fb556dabd86e6e
Tegra20 SoC supports only S/PDIF source for HDMI audio. Register ASoC HDMI
S/PDIF CODEC for Tegra20, it will be linked with the S/PDIF CPU DAI.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drm/tegra: hdmi: Unwind tegra_hdmi_init() errors2021-12-16T13:07:07ZDmitry Osipenko2021-12-04T14:37:17Zurn:sha1:7e67e986194a3648bf471e16f89cb5f61377bb4f
Add missing error unwinding to tegra_hdmi_init(), for consistency.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drm/tegra: Fix reference leak when pm_runtime_get_sync() fails2021-01-15T16:24:51ZQinglang Miao2020-12-01T12:56:31Zurn:sha1:dcdfe2712b68f1e9dbf4f1a96ad59b80e5cc0ef7
The PM reference count is not expected to be incremented on return in
these Tegra functions.
However, pm_runtime_get_sync() will increment the PM reference count
even on failure. Forgetting to put the reference again will result in
a leak.
Replace it with pm_runtime_resume_and_get() to keep the usage counter
balanced.
Fixes: fd67e9c6ed5a ("drm/tegra: Do not implement runtime PM")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drm/tegra: Clean up GPIO includes2020-04-17T15:16:22ZLinus Walleij2020-04-15T12:24:27Zurn:sha1:ac2caae61e566dc0a45ac264f5484e619366ce42
The Tegra DRM drivers includes the legacy GPIO headers
<linux/gpio.h> and <linux/of_gpio.h> but what it really
uses is <linux/gpio/consumer.h> since only gpio_desc
structs are ever referenced.
Include the right header on the top level tegra/drm.h
file and drop all the surplus includes.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200415122427.111769-1-linus.walleij@linaro.org
drm/tegra: Use simple encoder2020-04-02T12:16:45ZThomas Zimmermann2020-03-05T15:59:43Zurn:sha1:4d0e95e0e5679936b45848826aa080ced1ba40c8
The tegra driver uses empty implementations for its encoders. Replace
the code with the generic simple encoder.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20200305155950.2705-16-tzimmermann@suse.de