kernel.git/drivers/firewire/fw-device.c, branch linux-2.6.30.y

firewire: core: optimize propagation of BROADCAST_CHANNEL

2009-03-24T19:56:52Z

Cache the test result of whether a device implements BROADCAST_CHANNEL. This minimizes traffic on the bus after each bus reset. A majority of devices does not implement BROADCAST_CHANNEL. Remove busy retries; just rely on the hardware to retry requests to busy responders. Remove unnecessary log messages. Rename the flag is_irm to broadcast_channel_allocated to better reflect its meaning. Reset the flag earlier in fw_core_handle_bus_reset. Pass the generation down as a call parameter; that way generation can't be newer than card->broadcast_channel_allocated and device->node_id. Signed-off-by: Stefan Richter

firewire: broadcast channel support

2009-03-24T19:56:49Z

This patch adds the ISO broadcast channel support that is required of a 1394a IRM. In specific, if the local device the IRM, it allocates ISO channel 31 and sets the broadcast channel register of all devices on the local bus to BROADCAST_CHANNEL_INITIAL | BROADCAST_CHANNEL_VALID to indicate that channel 31 can be use for broadcast messages. One minor complication is that on startup the local device may become IRM before all the devices on the bus have been enumerated by the stack. Therefore we have to keep a "the local device is IRM" flag and possibly set the broadcast channel register of new devices at enumeration time. Signed-off-by: Jay Fenlason Signed-off-by: Stefan Richter

firewire: normalize a variable name

2009-03-24T19:56:48Z

Standardize on if (err) handle_error; and if (ret < 0) handle_error; Don't call a variable err if we store values in it which mean success. Also, offset some return statements by a blank line since this how we do it in drivers/firewire. Signed-off-by: Stefan Richter

firewire: core: remove condition which is always false

2009-03-24T19:56:47Z

reread_bus_info_block() only gets to see devices whose config_rom_length is at least 6 (ROM header, bus info block, root directory header). Signed-off-by: Stefan Richter

firewire: core: move some functions

2009-03-24T19:56:47Z

Signed-off-by: Stefan Richter

firewire: core: clean up includes

2009-03-24T19:56:47Z

Signed-off-by: Stefan Richter

firewire: remove line breaks before function names

2009-03-24T19:56:40Z

type function_name(parameters); is nice to look at but was not used consistently. Signed-off-by: Stefan Richter

firewire: convert client_list_lock to mutex

2009-03-24T19:56:37Z

So far it is only taken in non-atomic contexts. Signed-off-by: Stefan Richter

firewire: add a client_list_lock

2009-03-24T19:56:36Z

This adds a client_list_lock, which only protects the device's client_list, so that future versions of the driver can call code that takes the card->lock while holding the client_list_lock. Adding this lock is much simpler than adding __ versions of all the functions that the future version may need. The one ordering issue is to make sure code never takes the client_list_lock with card->lock held. Since client_list_lock is only used in three places, that isn't hard. Signed-off-by: Jay Fenlason Update fill_bus_reset_event() accordingly. Include linux/spinlock.h. Signed-off-by: Stefan Richter

firewire: core: optimize card shutdown

2009-01-24T19:40:12Z

This fixes a regression by "firewire: keep highlevel drivers attached during brief connection loss": There were 2 seconds unnecessary waiting added to the shutdown procedure of each controller. We use card->link as status flag to signal the device handler that there is no use to wait for a come-back. Signed-off-by: Stefan Richter